-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): add supported settings to values.yaml based on settings.go #9380
Conversation
|
Welcome @krichter722! |
Signed-off-by: Karl-Philipp Richter <[email protected]>
319841e
to
23d3295
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, krichter722 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on https://github.com/kubernetes/dashboard/blob/master/modules/web/pkg/settings/settings.go. The values all seem to work, they're just missing in the "docs" (
values.yaml
is kind of docs for a chart).