-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo error in args for api module #9741
Conversation
Welcome @warjiang! |
another problem i want to metioned is that, why the default value for |
@floreks @maciaszczykm can you help me to review this one~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9741 +/- ##
=======================================
Coverage 35.88% 35.88%
=======================================
Files 301 301
Lines 14503 14503
Branches 183 183
=======================================
Hits 5204 5204
Misses 9075 9075
Partials 224 224 |
for all eth interface, the
insecure-bind-address
should be set as0.0.0.0