Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4247: correct the milestone at kep.yaml #5050

Merged
merged 1 commit into from
Jan 18, 2025
Merged

KEP-4247: correct the milestone at kep.yaml #5050

merged 1 commit into from
Jan 18, 2025

Conversation

sanposhiho
Copy link
Member

  • One-line PR description: Change the beta milestone to v1.32
  • Other comments: So, the context is that we once graduate it as beta at v1.28, but we soon reverted it because we found a memory leak bug. v1.32 fixes the bug, and we tried again to graduate it to beta. So, I believe we should note the graduation of beta was v1.32.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2025
@sanposhiho
Copy link
Member Author

/cc @alculquicondor

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 18, 2025
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2025
@sanposhiho sanposhiho mentioned this pull request Jan 18, 2025
Open
Huang-Wei
Huang-Wei reviewed Jan 18, 2025
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1d5ad90 into kubernetes:master Jan 18, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Scheduling
Archived in project
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
3 participants
@sanposhiho @k8s-ci-robot @Huang-Wei