-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from "extensions.v1beta1" to "networking.v1beta1" #806
Conversation
bowei
commented
Jul 29, 2019
This migrates our code to use the networking.v1beta1.Ingress* API types instead of extensions.v1beta1. This also fixes fixture YAMLs to use "networking.k8s.io" as the fully-qualified resource kind.
/assign @rramkumar1 @freehan |
cc: @liggitt |
@bowei We would need to update the YAML's in our GCP documentation as well. [1] https://cloud.google.com/kubernetes-engine/docs/concepts/ingress |
Will it still recognize ingress objects in extension api group? I assume API machinery should have handled this kind of backward compatibility, right? |
Yes, asked Jordan, this should work as long as it is used with v1.15+ k8s clusters |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |