Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop InTreePluginAWSUnregister feature gate for k8s 1.31 and above #16698

Conversation

dims
Copy link
Member

@dims dims commented Jul 25, 2024

possible Fix for CI job failures:

E0725 12:16:22.804670   27684 run.go:72] "command failed" err="failed to set feature gates from initial flags-based config: unrecognized feature gate: InTreePluginAWSUnregister"

k8s cleanup PR for some feature gates:
https://github.com/kubernetes/kubernetes/pull/124815/files

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2024
@dims
Copy link
Member Author

dims commented Jul 25, 2024

/assign @zetaab @hakman @justinsb

@k8s-ci-robot k8s-ci-robot requested review from hakman and olemarkus July 25, 2024 16:31
@dims dims force-pushed the drop-InTreePluginAWSUnregister-for-k8s-1.31-and-above branch from 69c9755 to 535af3f Compare July 25, 2024 16:31
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@hakman
Copy link
Member

hakman commented Jul 25, 2024

Thanks @dims 👍

@k8s-ci-robot k8s-ci-robot merged commit 42260d5 into kubernetes:master Jul 25, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jul 25, 2024
@rifelpet
Copy link
Member

/milestone v1.31

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants