Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kindnet permissions #17213

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

aojea
Copy link
Member

@aojea aojea commented Jan 15, 2025

kindnet needs to read the node configuration to obtain the dns nameserver and configuration, so it can implement the dnscache restricting the traffic to the in-cluster dns traffic only and avoid any possible disruption on the network

Fixes: aojea/kindnet#159

/assign @hakman

Change-Id: Ib910093371ea69892033b469b723b0a5daf00892
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
@aojea
Copy link
Member Author

aojea commented Jan 15, 2025

/test pull-kops-e2e-cni-kindnet

@aojea
Copy link
Member Author

aojea commented Jan 15, 2025

this is working now

I0115 11:49:40.610034 1 agent.go:118] "Obtained DNS config from kubelet" nameservers=["100.64.0.10"] search="cluster.local" resolver="/run/systemd/resolve/resolv.conf"

@hakman @justinsb can you please merge?

@aojea
Copy link
Member Author

aojea commented Jan 15, 2025

the failing jos is pending #17206

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2025
@justinsb
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@aojea: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-gce-cni-kindnet 32854ff link false /test pull-kops-e2e-gce-cni-kindnet
pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons 32854ff link false /test pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Jan 15, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit dc30826 into kubernetes:master Jan 15, 2025
26 of 28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invesitate Kops to read node configz endpoints
4 participants