Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make --admin configurable to rolling-update #17274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make --admin configurable to rolling-update #17274

wants to merge 1 commit into from

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Feb 20, 2025 •
edited
Loading

see #17262 (comment)

this PR will add --admin configurable to rolling-update command with default value 18 hours

cc @justinsb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zetaab. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2025
@zetaab zetaab force-pushed the feat/fixrollingupdatetime branch from a7dd560 to 0fb6ed3 Compare February 20, 2025 18:51
@k8s-ci-robot k8s-ci-robot added area/documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2025
justinsb
justinsb reviewed Feb 21, 2025
View reviewed changes
@zetaab zetaab force-pushed the feat/fixrollingupdatetime branch from 0fb6ed3 to 6ddfae5 Compare February 22, 2025 08:01
@zetaab zetaab force-pushed the feat/fixrollingupdatetime branch from 6ddfae5 to d5cea90 Compare February 22, 2025 08:02
This was referenced Feb 22, 2025
Open
Open
@zetaab
Copy link
Member Author

zetaab commented Feb 22, 2025

cc @hakman

@zetaab
Copy link
Member Author

zetaab commented Feb 22, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@hakman hakman Awaiting requested review from hakman

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees
No one assigned
Labels
area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zetaab @k8s-ci-robot @justinsb