Fix: check if addon is enabled before doing validation

[kadern0]

Fixes: #15432, #15429, #15431, #15430

$ ./out/minikube addons list
|-----------------------------|----------|--------------|--------------------------------|
|         ADDON NAME          | PROFILE  |    STATUS    |           MAINTAINER           |
|-----------------------------|----------|--------------|--------------------------------|
| ambassador                  | minikube | disabled     | 3rd party (Ambassador)         |
| auto-pause                  | minikube | disabled     | Google                         |
| cloud-spanner               | minikube | disabled     | Google                         |
| csi-hostpath-driver         | minikube | disabled     | Kubernetes                     |
| dashboard                   | minikube | disabled     | Kubernetes                     |
| default-storageclass        | minikube | enabled ✅   | Kubernetes                     |
| efk                         | minikube | disabled     | 3rd party (Elastic)            |
| freshpod                    | minikube | disabled     | Google                         |
| gcp-auth                    | minikube | disabled     | Google                         |
| gvisor                      | minikube | disabled     | Google                         |
| headlamp                    | minikube | disabled     | 3rd party (kinvolk.io)         |
| helm-tiller                 | minikube | disabled     | 3rd party (Helm)               |
| inaccel                     | minikube | disabled     | 3rd party (InAccel             |
|                             |          |              | [[email protected]])            |
| ingress                     | minikube | disabled     | Kubernetes                     |
| ingress-dns                 | minikube | disabled     | Google                         |
| istio                       | minikube | disabled     | 3rd party (Istio)              |
| istio-provisioner           | minikube | disabled     | 3rd party (Istio)              |
| kong                        | minikube | disabled     | 3rd party (Kong HQ)            |
| kubevirt                    | minikube | disabled     | 3rd party (KubeVirt)           |
| logviewer                   | minikube | disabled     | 3rd party (unknown)            |
| metallb                     | minikube | disabled     | 3rd party (MetalLB)            |
| metrics-server              | minikube | disabled     | Kubernetes                     |
| nvidia-driver-installer     | minikube | disabled     | Google                         |
| nvidia-gpu-device-plugin    | minikube | disabled     | 3rd party (Nvidia)             |
| olm                         | minikube | disabled     | 3rd party (Operator Framework) |
| pod-security-policy         | minikube | disabled     | 3rd party (unknown)            |
| portainer                   | minikube | disabled     | 3rd party (Portainer.io)       |
| registry                    | minikube | disabled     | Google                         |
| registry-aliases            | minikube | disabled     | 3rd party (unknown)            |
| registry-creds              | minikube | disabled     | 3rd party (UPMC Enterprises)   |
| storage-provisioner         | minikube | enabled ✅   | Google                         |
| storage-provisioner-gluster | minikube | disabled     | 3rd party (Gluster)            |
| volumesnapshots             | minikube | disabled     | Kubernetes                     |
|-----------------------------|----------|--------------|--------------------------------|

Before

$ minikube addons disable gvisor

❌  Exiting due to MK_ADDON_DISABLE: run callbacks: running validations: [
This addon can only be enabled with the containerd runtime backend. To enable this backend, please first stop minikube with:

minikube stop

and then start minikube again with the following flags:

minikube start --container-runtime=containerd --docker-opt containerd=/var/run/containerd/containerd.sock]

╭───────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                           │
│    😿  If the above advice does not help, please let us know:                             │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                           │
│                                                                                           │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│    Please also attach the following file to the GitHub issue:                             │
│    - /tmp/minikube_addons_569b151b47196d038af25537206255c050ace6fd_0.log                  │
│                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────╯

After

$ ./out/minikube addons disable gvisor
🌑  "The 'gvisor' addon is disabled

Before:

 minikube addons disable gcp-auth

❌  Exiting due to MK_ADDON_DISABLE: run callbacks: running callbacks: [Process exited with status 1]

╭───────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                           │
│    😿  If the above advice does not help, please let us know:                             │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                           │
│                                                                                           │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│    Please also attach the following file to the GitHub issue:                             │
│    - /tmp/minikube_addons_2c4fde7ba5d6af1ee47e28fd9619be21ed484a50_0.log                  │
│                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────╯

After:

$ ./out/minikube addons disable gcp-auth
🌑  "The 'gcp-auth' addon is disabled

Before:

$ minikube addons disable testing

❌  Exiting due to MK_ADDON_DISABLE: run callbacks: testing is not a valid addon

╭───────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                           │
│    😿  If the above advice does not help, please let us know:                             │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                           │
│                                                                                           │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│    Please also attach the following file to the GitHub issue:                             │
│    - /tmp/minikube_addons_4755f700bf6c955ce4ad0731b6be6682109661fe_0.log                  │
│                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────╯

After:

$ ./out/minikube addons disable testing

❌  Exiting due to MK_ADDON_DISABLE: "'testing' is not a valid minikube addon

[k8s-ci-robot]

Hi @kadern0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

/ok-to-test

[medyagh]

do you mind posting before/after this PR ? in the PR description?

[spowelljr]

Thanks for the PR, just a few things, also, once you're done making the changes could you also run make generate-docs to add the new message to translations, thanks

[spowelljr]

Could you also add a test for this, just try disabling one of the addons that was throwing an error and make sure it's a non-zero exit code

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16139) |
+----------------+----------+---------------------+
| minikube start | 50.4s    | 50.4s               |
| enable ingress | 25.5s    | 25.9s               |
+----------------+----------+---------------------+

Times for minikube start: 50.1s 51.3s 51.4s 51.1s 48.3s
Times for minikube (PR 16139) start: 51.6s 50.4s 47.2s 52.5s 50.2s

Times for minikube ingress: 25.2s 27.7s 25.1s 24.1s 25.1s
Times for minikube (PR 16139) ingress: 24.1s 28.2s 25.1s 24.1s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16139) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 23.4s               |
| enable ingress | 27.1s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 23.1s 22.8s 22.9s 23.2s
Times for minikube (PR 16139) start: 24.1s 22.9s 23.3s 22.9s 23.7s

Times for minikube ingress: 23.0s 49.5s 20.5s 22.0s 20.5s
Times for minikube (PR 16139) ingress: 22.1s 21.5s 49.5s 20.1s 21.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16139) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.4s               |
| enable ingress | 39.0s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 22.7s 20.8s 21.4s 21.7s
Times for minikube (PR 16139) start: 21.0s 21.3s 22.3s 21.4s 21.1s

Times for minikube ingress: 32.0s 19.0s 31.5s 31.5s 81.0s
Times for minikube (PR 16139) ingress: 19.0s 33.0s 31.5s 20.5s 32.5s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux	TestRunningBinaryUpgrade (gopogh)	3.66 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	5.26 (chart)
KVM_Linux_containerd	TestPreload (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

[spowelljr]

Looks good, thanks for the PR!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadern0, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment