-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minikube start
not working without sudo
on none driver
#16408
Conversation
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kvm2 driver with docker runtime
Times for minikube ingress: 25.7s 25.2s 23.7s 27.7s 25.2s Times for minikube start: 51.9s 52.9s 48.4s 47.3s 48.6s docker driver with docker runtime
Times for minikube start: 21.6s 21.8s 21.8s 22.6s 21.5s Times for minikube ingress: 22.0s 83.0s 22.0s 20.5s 21.0s docker driver with containerd runtime
Times for minikube start: 20.9s 20.9s 20.0s 23.5s 20.6s Times for minikube ingress: 36.5s 49.0s 31.5s 49.5s 33.0s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #16400
Closes #16393
Discovered that the regression was caused by fd549f3
minikube/pkg/minikube/cni/cni.go
Lines 171 to 175 in fd549f3
Before, no CNI would be used, but now if using Docker CRI with K8s v1.24+, we default to using the bridge CNI and it's failing to
chmod
the bridge conflistchmod /etc/cni/net.d/1-k8s.conflist: permission denied
.The cause of the chmod permission error is we were calling
os.Chmod
on files in the/var/lib/minikube/binaries/<K8s_version>
dir which has the ownership ofroot:root
, causing the error.Changed it so we chmod the file in the tmp dir before we copy them to their destination, as we may not have permission to chmod them after we copy them, like above.
Also removed
sudo -E
from none docs and none tests so we will catch something like this going forward.