-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISO: Add 50-dnssec.conf to fix DNSSEC issue #18830
Conversation
ok-to-build-iso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there is no info on why this configuration is there, and the commit message is has no info. One can go and find the PR and then find the issue, but it will much easier if the actual file had a link the the issue, or at least the commit message was linked to the issue.
Another issue - this setting is good for local user modifications - using 99-.conf so other configuration will not accidentally override this config. But changes delivered by minikube should use a lower number (e.g. 50-.conf) so someone can override the minikube setting locally (e.g using ~/.minikube/files/). |
Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
Tested staring new cluster with the iso:
|
can confirm. This fixes #18705 |
Some machines configurations no longer have DNSSEC=no set as the system default after the Buildroot update. This results in errors when trying to pull imagse from insecure locations. Adding 50-dnssec.conf that has DNSSEC=no to override system default.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #18705
Implements #18705 (comment)
Some machines configurations no longer have DNSSEC=no set as the system default after the Buildroot update.
This results in errors when trying to pull imagse from insecure locations.
Adding 50-dnssec.conf that has DNSSEC=no to override system default.