Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect native-ssh param properly #8290

Merged
merged 6 commits into from
May 28, 2020
Merged

respect native-ssh param properly #8290

merged 6 commits into from
May 28, 2020

Conversation

sharifelgamal
Copy link
Collaborator

We were calling ssh.SetDefaultClient too early, so CreateSSHShell was overriding the property back to external no matter what was passed in.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2020
@k8s-ci-robot k8s-ci-robot requested a review from afbjorklund May 27, 2020 22:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from priyawadhwa May 27, 2020 22:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @sharifelgamal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test 
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.10.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.10.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="e976d877bd4c7b8c335bb2851a1c5147a0da5fd7"" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.26.0'
golangci/golangci-lint info found version: 1.26.0 for v1.26.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
WARN [runner] Can't run linter unused: buildssa: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/machine/cluster_test.go:457:74: too few arguments in call to CreateSSHShell] 
WARN [runner] Can't run linter goanalysis_metalinter: S1033: failed prerequisites: [([email protected]/minikube/pkg/minikube/machine [k8s.io/minikube/pkg/minikube/machine.test], [email protected]/minikube/pkg/minikube/machine [k8s.io/minikube/pkg/minikube/machine.test]): analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/machine/cluster_test.go:457:74: too few arguments in call to CreateSSHShell]] 
ERRO Running error: S1033: failed prerequisites: [([email protected]/minikube/pkg/minikube/machine [k8s.io/minikube/pkg/minikube/machine.test], [email protected]/minikube/pkg/minikube/machine [k8s.io/minikube/pkg/minikube/machine.test]): analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/machine/cluster_test.go:457:74: too few arguments in call to CreateSSHShell]] 
Makefile:387: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 3
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:271: recipe for target 'test' failed
make: *** [test] Error 4

2nd Build

View build log

make test 
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.10.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.10.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="e976d877bd4c7b8c335bb2851a1c5147a0da5fd7"" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: extracting github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: extracting github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
go: extracting github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
go: finding github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: finding github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: finding github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/spf13/viper v1.6.1
go: downloading github.com/google/go-containerregistry v0.0.0-20200131185320-aec8da010de2
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: extracting github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: extracting github.com/spf13/viper v1.6.1
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: extracting github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: extracting github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading gopkg.in/yaml.v2 v2.2.8
go: extracting github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/mitchellh/go-ps v0.0.0-20170309133038-4fdf99ab2936
go: extracting github.com/mitchellh/go-ps v0.0.0-20170309133038-4fdf99ab2936
go: extracting gopkg.in/yaml.v2 v2.2.8
go: extracting github.com/google/go-containerregistry v0.0.0-20200131185320-aec8da010de2
go: extracting github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/spf13/afero v1.2.2
go: extracting k8s.io/client-go v0.17.3
go: downloading k8s.io/kubernetes v1.17.3
go: downloading k8s.io/api v0.17.3
go: extracting github.com/hashicorp/hcl v1.0.0
go: extracting github.com/spf13/afero v1.2.2
go: downloading github.com/magiconair/properties v1.8.1
go: extracting github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/spf13/cobra v1.0.0
go: downloading golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/pelletier/go-toml v1.6.0
go: extracting github.com/spf13/cobra v1.0.0
go: extracting github.com/pelletier/go-toml v1.6.0
go: extracting github.com/magiconair/properties v1.8.1
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/mitchellh/mapstructure v1.1.2
go: extracting golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: extracting github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: extracting github.com/pkg/errors v0.9.1
go: downloading golang.org/x/text v0.3.2
go: extracting github.com/mitchellh/mapstructure v1.1.2
go: extracting github.com/spf13/pflag v1.0.5
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: extracting github.com/olekukonko/tablewriter v0.0.4
go: extracting github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: extracting github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: extracting github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: extracting github.com/cheggaaa/pb v1.0.27
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading k8s.io/apimachinery v0.17.3
go: extracting github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: extracting github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading cloud.google.com/go v0.45.1
go: extracting github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: extracting k8s.io/api v0.17.3
go: extracting k8s.io/apimachinery v0.17.3
go: extracting github.com/VividCortex/ewma v1.1.1
go: downloading github.com/subosito/gotenv v1.2.0
go: extracting github.com/subosito/gotenv v1.2.0
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: extracting github.com/hashicorp/go-safetemp v1.0.0
go: downloading golang.org/x/crypto v0.0.0-20200302210943-78000ba7a073
go: extracting github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: extracting github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: extracting github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/aws/aws-sdk-go v1.27.1
go: extracting cloud.google.com/go v0.45.1
go: extracting golang.org/x/crypto v0.0.0-20200302210943-78000ba7a073
go: extracting golang.org/x/text v0.3.2
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: downloading google.golang.org/grpc v1.26.0
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: extracting google.golang.org/grpc v1.26.0
go: downloading golang.org/x/sys v0.0.0-20200124204421-9fbb57f87de9
go: extracting github.com/mattn/go-runewidth v0.0.7
go: extracting github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: extracting k8s.io/kubernetes v1.17.3
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: extracting github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: downloading github.com/mattn/go-colorable v0.1.2
go: extracting github.com/mattn/go-colorable v0.1.2
go: extracting github.com/docker/go-connections v0.4.0
go: downloading github.com/gogo/protobuf v1.3.1
go: extracting github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading google.golang.org/api v0.9.0
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: extracting github.com/spf13/jwalterweatherman v1.1.0
go: extracting github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/sirupsen/logrus v1.4.2
go: extracting github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: extracting golang.org/x/sys v0.0.0-20200124204421-9fbb57f87de9
go: extracting github.com/aws/aws-sdk-go v1.27.1
go: extracting github.com/gogo/protobuf v1.3.1
go: extracting github.com/sirupsen/logrus v1.4.2
go: downloading golang.org/x/net v0.0.0-20200301022130-244492dfa37a
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: extracting github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: extracting gopkg.in/inf.v0 v0.9.1
go: extracting google.golang.org/api v0.9.0
go: extracting github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/hashicorp/go-version v1.1.0
go: extracting golang.org/x/net v0.0.0-20200301022130-244492dfa37a
go: downloading github.com/fsnotify/fsnotify v1.4.7
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: downloading github.com/golang/protobuf v1.3.2
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/otiai10/copy v1.0.2
go: extracting github.com/fsnotify/fsnotify v1.4.7
go: downloading github.com/opencontainers/image-spec v1.0.1
go: extracting sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: extracting github.com/otiai10/copy v1.0.2
go: downloading google.golang.org/genproto v0.0.0-20200117163144-32f20d992d24
go: downloading github.com/hashicorp/go-cleanhttp v0.5.0
go: extracting github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: extracting github.com/hashicorp/go-version v1.1.0
go: extracting github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/prometheus/client_golang v1.1.0
go: downloading golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45
go: extracting k8s.io/cluster-bootstrap v0.17.3
go: extracting k8s.io/klog v1.0.0
go: extracting github.com/golang/protobuf v1.3.2
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/fatih/color v1.7.0
go: extracting k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading k8s.io/component-base v0.17.3
go: extracting github.com/opencontainers/image-spec v1.0.1
go: extracting golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45
go: extracting github.com/hashicorp/go-cleanhttp v0.5.0
go: extracting github.com/prometheus/client_golang v1.1.0
go: downloading go.opencensus.io v0.22.0
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/miekg/dns v1.1.4
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: extracting github.com/davecgh/go-spew v1.1.1
go: extracting github.com/libvirt/libvirt-go v3.4.0+incompatible
go: extracting k8s.io/component-base v0.17.3
go: extracting github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: extracting github.com/fatih/color v1.7.0
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/prometheus/common v0.6.0
go: extracting google.golang.org/genproto v0.0.0-20200117163144-32f20d992d24
go: downloading sigs.k8s.io/yaml v1.1.0
go: extracting go.opencensus.io v0.22.0
go: extracting github.com/miekg/dns v1.1.4
go: extracting github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: extracting k8s.io/kubectl v0.17.3
go: extracting sigs.k8s.io/yaml v1.1.0
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/docker/go-units v0.4.0
go: extracting github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/ulikunitz/xz v0.5.5
go: extracting github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading gopkg.in/ini.v1 v1.51.1
go: downloading github.com/modern-go/reflect2 v1.0.1
go: extracting github.com/prometheus/common v0.6.0
go: downloading github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: extracting github.com/docker/go-units v0.4.0
go: downloading github.com/imdario/mergo v0.3.8
go: extracting github.com/beorn7/perks v1.0.1
go: extracting github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: extracting github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: extracting github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: extracting github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: extracting github.com/ulikunitz/xz v0.5.5
go: extracting github.com/matttproud/golang_protobuf_extensions v1.0.1
go: extracting gopkg.in/ini.v1 v1.51.1
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/json-iterator/go v1.1.8
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: extracting github.com/modern-go/reflect2 v1.0.1
go: downloading golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
go: downloading k8s.io/kubelet v0.17.3
go: extracting github.com/imdario/mergo v0.3.8
go: downloading github.com/prometheus/procfs v0.0.5
go: extracting github.com/google/uuid v1.1.1
go: extracting github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: extracting k8s.io/kubelet v0.17.3
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: extracting github.com/json-iterator/go v1.1.8
go: downloading github.com/google/gofuzz v1.0.0
go: extracting github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: extracting golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: extracting github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: extracting github.com/spf13/cast v1.3.1
go: extracting github.com/googleapis/gnostic v0.3.0
go: downloading k8s.io/kube-proxy v0.17.3
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: extracting github.com/docker/docker-credential-helpers v0.6.3
go: extracting github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/google/go-cmp v0.3.2-0.20191028172631-481baca67f93
go: downloading github.com/mattn/go-isatty v0.0.11
go: extracting github.com/prometheus/procfs v0.0.5
go: extracting github.com/google/gofuzz v1.0.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/golang/groupcache v0.0.0-20190129154638-5b532d6fd5ef
go: extracting github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af
go: extracting k8s.io/kube-proxy v0.17.3
go: extracting github.com/google/go-cmp v0.3.2-0.20191028172631-481baca67f93
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: extracting github.com/shurcooL/sanitized_anchor_name v1.0.0
go: extracting github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: extracting github.com/golang/groupcache v0.0.0-20190129154638-5b532d6fd5ef
go: extracting github.com/mattn/go-isatty v0.0.11
go: extracting github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af
go: extracting github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: extracting k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: finding github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: finding github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: finding github.com/pkg/errors v0.9.1
go: finding github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: finding github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: finding github.com/docker/go-units v0.4.0
go: finding github.com/spf13/cobra v1.0.0
go: finding github.com/olekukonko/tablewriter v0.0.4
go: finding github.com/blang/semver v3.5.0+incompatible
go: finding k8s.io/client-go v0.17.3
go: finding github.com/libvirt/libvirt-go v3.4.0+incompatible
go: finding github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: finding github.com/spf13/viper v1.6.1
go: finding golang.org/x/crypto v0.0.0-20200302210943-78000ba7a073
go: finding github.com/mattn/go-runewidth v0.0.7
go: finding github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: finding github.com/spf13/pflag v1.0.5
go: finding github.com/mattn/go-isatty v0.0.11
go: finding k8s.io/api v0.17.3
go: finding github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: finding github.com/imdario/mergo v0.3.8
go: finding github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: finding golang.org/x/sys v0.0.0-20200124204421-9fbb57f87de9
go: finding github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: finding k8s.io/apimachinery v0.17.3
go: finding github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: finding github.com/google/go-containerregistry v0.0.0-20200131185320-aec8da010de2
go: finding github.com/gogo/protobuf v1.3.1
go: finding github.com/google/uuid v1.1.1
go: finding github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: finding github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: finding github.com/fsnotify/fsnotify v1.4.7
go: finding github.com/mitchellh/go-ps v0.0.0-20170309133038-4fdf99ab2936
go: finding github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: finding github.com/hashicorp/hcl v1.0.0
go: finding github.com/shirou/gopsutil v2.18.12+incompatible
go: finding cloud.google.com/go v0.45.1
go: finding github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: finding github.com/magiconair/properties v1.8.1
go: finding github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: finding github.com/google/gofuzz v1.0.0
go: finding github.com/mitchellh/mapstructure v1.1.2
go: finding golang.org/x/text v0.3.2
go: finding golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
go: finding sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: finding github.com/docker/distribution v2.7.1+incompatible
go: finding k8s.io/klog v1.0.0
go: finding github.com/docker/docker-credential-helpers v0.6.3
go: finding github.com/pelletier/go-toml v1.6.0
go: finding github.com/otiai10/copy v1.0.2
go: finding github.com/cpuguy83/go-md2man/v2 v2.0.0
go: finding github.com/cenkalti/backoff v2.2.1+incompatible
go: finding gopkg.in/inf.v0 v0.9.1
go: finding github.com/golang/protobuf v1.3.2
go: finding github.com/spf13/afero v1.2.2
go: finding github.com/googleapis/gnostic v0.3.0
go: finding github.com/spf13/cast v1.3.1
go: finding github.com/googleapis/gax-go/v2 v2.0.5
go: finding github.com/russross/blackfriday/v2 v2.0.1
go: finding golang.org/x/net v0.0.0-20200301022130-244492dfa37a
go: finding github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: finding github.com/prometheus/client_golang v1.1.0
go: finding github.com/spf13/jwalterweatherman v1.1.0
go: finding gopkg.in/yaml.v2 v2.2.8
go: finding github.com/cheggaaa/pb/v3 v3.0.1
go: finding google.golang.org/genproto v0.0.0-20200117163144-32f20d992d24
go: finding k8s.io/kubernetes v1.17.3
go: finding github.com/opencontainers/go-digest v1.0.0-rc1
go: finding google.golang.org/api v0.9.0
go: finding google.golang.org/grpc v1.26.0
go: finding golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
go: finding github.com/subosito/gotenv v1.2.0
go: finding go.opencensus.io v0.22.0
go: finding github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: finding github.com/shurcooL/sanitized_anchor_name v1.0.0
go: finding gopkg.in/ini.v1 v1.51.1
go: finding github.com/VividCortex/ewma v1.1.1
go: finding github.com/docker/go-connections v0.4.0
go: finding k8s.io/kubectl v0.17.3
go: finding k8s.io/component-base v0.17.3
go: finding github.com/fatih/color v1.7.0
go: finding github.com/beorn7/perks v1.0.1
go: finding github.com/json-iterator/go v1.1.8
go: finding github.com/mattn/go-colorable v0.1.2
go: finding github.com/opencontainers/image-spec v1.0.1
go: finding github.com/modern-go/reflect2 v1.0.1
go: finding github.com/hashicorp/golang-lru v0.5.3
go: finding golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45
go: finding github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: finding github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: finding github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: finding github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: finding github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: finding github.com/prometheus/common v0.6.0
go: finding github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: finding github.com/davecgh/go-spew v1.1.1
go: finding github.com/sirupsen/logrus v1.4.2
go: finding github.com/prometheus/procfs v0.0.5
go: finding k8s.io/cluster-bootstrap v0.17.3
go: finding github.com/matttproud/golang_protobuf_extensions v1.0.1
go: finding github.com/mitchellh/go-wordwrap v1.0.0
go: finding k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: finding sigs.k8s.io/yaml v1.1.0
go: finding github.com/aws/aws-sdk-go v1.27.1
go: finding github.com/golang/groupcache v0.0.0-20190129154638-5b532d6fd5ef
go: finding k8s.io/kube-proxy v0.17.3
go: finding k8s.io/kubelet v0.17.3
go: finding github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: finding github.com/hashicorp/go-cleanhttp v0.5.0
go: finding github.com/miekg/dns v1.1.4
go: finding github.com/hashicorp/go-safetemp v1.0.0
go: finding github.com/hashicorp/go-version v1.1.0
go: finding github.com/mitchellh/go-homedir v1.1.0
go: finding github.com/mitchellh/go-testing-interface v1.0.0
go: finding github.com/ulikunitz/xz v0.5.5
go: finding k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: finding github.com/google/go-cmp v0.3.2-0.20191028172631-481baca67f93
go: finding github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af
go: finding github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: finding github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading github.com/pmezard/go-difflib v1.0.0
go: extracting github.com/evanphx/json-patch v4.5.0+incompatible
go: extracting github.com/pmezard/go-difflib v1.0.0
go: finding github.com/pmezard/go-difflib v1.0.0
go: finding github.com/evanphx/json-patch v4.5.0+incompatible
ok  	k8s.io/minikube/cmd/minikube/cmd	6.319s	coverage: 20.7% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.154s	coverage: 21.6% of statements
ok  	k8s.io/minikube/pkg/addons	0.034s	coverage: 56.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.016s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.014s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.025s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.847s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.064s	coverage: 63.2% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.011s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.006s	coverage: 88.9% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.077s	coverage: 16.9% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.018s	coverage: 3.8% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.147s	coverage: 67.3% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.032s	coverage: 40.6% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.041s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.051s	coverage: 37.3% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.010s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.053s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.014s	coverage: 51.9% of statements
# k8s.io/minikube/pkg/minikube/machine [k8s.io/minikube/pkg/minikube/machine.test]
pkg/minikube/machine/cluster_test.go:457:26: not enough arguments in call to CreateSSHShell
	have (*tests.MockAPI, config.ClusterConfig, config.Node, []string)
	want (libmachine.API, config.ClusterConfig, config.Node, []string, bool)
ok  	k8s.io/minikube/pkg/minikube/logs	0.032s	coverage: 1.3% of statements
FAIL	k8s.io/minikube/pkg/minikube/machine [build failed]
ok  	k8s.io/minikube/pkg/minikube/notify	0.018s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.046s	coverage: 67.4% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	0.269s	coverage: 54.7% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.035s	coverage: 91.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.007s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.018s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.054s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.016s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.023s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.735s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.617s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.003s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.015s	coverage: 0.0% of statements
FAIL
Makefile:271: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: ff89a610-a06a-11ea-aa49-9d3926c79f60

@codecov-commenter
Copy link

Codecov Report

Merging #8290 into master will increase coverage by 0.02%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8290      +/-   ##
==========================================
+ Coverage   34.35%   34.38%   +0.02%     
==========================================
  Files         147      147              
  Lines        9456     9456              
==========================================
+ Hits         3249     3251       +2     
+ Misses       5808     5805       -3     
- Partials      399      400       +1
Impacted Files Coverage Δ
cmd/minikube/cmd/ssh.go 15.00% <0.00%> (+2.50%) ⬆️
cmd/minikube/cmd/start.go 13.73% <0.00%> (ø)
pkg/minikube/machine/ssh.go 44.44% <60.00%> (+1.58%) ⬆️

@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 27, 2020
@kubernetes kubernetes deleted a comment from minikube-pr-bot May 27, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [64.246214544 62.858394378999996 66.60288870400001]
Average time for minikube: 64.56916587566667

Times for Minikube (PR 8290): [65.77142428 65.028435519 62.642068255999995]
Average time for Minikube (PR 8290): 64.48064268499999

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8290) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.061200 |           0.065482 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020410 |           0.019809 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.007698 |           0.003125 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.741944 |          40.808406 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 21.920218 |          21.728354 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.561565 |           1.274054 |
| components...                  |           |                    |
| * Enabled addons:              |  0.173506 |           0.505365 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.078458 |           0.072169 |
| configured to use "minikube"   |           |                    |
|                                |  0.004169 |           0.003879 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.628092187 27.525525639999998 26.119620931]
Average time for minikube: 27.091079585999996

Times for Minikube (PR 8290): [25.441173063 25.776903614 26.650396541]
Average time for Minikube (PR 8290): 25.95615773933333

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8290) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.070060 |           0.072684 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002660 |           0.002317 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.057396 |           0.060295 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.429303 |           7.583575 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.118617 |           0.115275 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.300675 |          17.205861 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.939718 |           0.847002 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.095603 |           0.002934 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.073812 |           0.063126 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003236 |           0.003088 |
+----------------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [65.65944745700001 63.195281552 65.80176584300001]
Average time for minikube: 64.88549828400001

Times for Minikube (PR 8290): [63.84391875399999 84.714953779 65.566571883]
Average time for Minikube (PR 8290): 71.37514813866666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8290) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.058536 |           0.059600 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020678 |           0.020587 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.005005 |           0.008203 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.650587 |          40.673622 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 21.970816 |          28.576338 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.329500 |           1.291748 |
| components...                  |           |                    |
| * Enabled addons:              |  0.777062 |           0.667670 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.066810 |           0.073507 |
| configured to use "minikube"   |           |                    |
|                                |  0.006504 |           0.003874 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.030453174 26.295547079 26.052373675]
Average time for minikube: 26.126124642666667

Times for Minikube (PR 8290): [25.606995775999998 26.686788384 26.948690414]
Average time for Minikube (PR 8290): 26.414158191333332

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8290) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.072697 |           0.074111 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002264 |           0.002628 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.059425 |           0.058206 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.407904 |           7.400630 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.116061 |           0.120355 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.201816 |          17.492779 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.149890 |           1.120138 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.049887 |           0.075278 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.060721 |           0.065734 |
| configured to use "minikube"           |           |                    |
|                                        |  0.005460 |           0.004300 |
+----------------------------------------+-----------+--------------------+

@sharifelgamal sharifelgamal merged commit a2c8823 into kubernetes:master May 28, 2020
@fmotrifork fmotrifork mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sharifelgamal @k8s-ci-robot @TravisBuddy @codecov-commenter @minikube-pr-bot @tstromberg @medyagh