Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature addition to network benchmark tests #2876

Open
ritwikranjan opened this issue Sep 9, 2024 · 8 comments · May be fixed by #2969
Open

Feature addition to network benchmark tests #2876

ritwikranjan opened this issue Sep 9, 2024 · 8 comments · May be fixed by #2969
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ritwikranjan
Copy link

What would you like to be added: I was looking into the network benchmarking tests available under /network/benchmarks/netperf. The tests present there are pretty old and very restrictive in how we study and publish them. Adding new test is not very trivial and there are a lot of conditionals involved. I was thinking of cleaning the way these network tests are written and also add additional output options like json which can be used to save and publish much more information than it do currently.

Why is this needed: This will make the tests more useful, easy to change, and more developer-friendly.

@ritwikranjan ritwikranjan added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 9, 2024
@aojea
Copy link
Member

aojea commented Sep 9, 2024

@ritwikranjan I will happy to review a new proposal, a google doc or something similar can work

@ritwikranjan
Copy link
Author

Sounds great, I will write a proposal and send it here!

@ritwikranjan
Copy link
Author

Hey @aojea, please find the doc attached, if it looks good I'll start working on a PR.
proposal_perf_tests.docx

@ritwikranjan
Copy link
Author

I have created a PR for first of a few changes I am planning to do on my fork. Feel free to take a look and suggest changes and improvements.

ritwikranjan#1

I will make all the changes on my fork and open an upstream PR.

ritwikranjan added a commit to ritwikranjan/perf-tests that referenced this issue Sep 21, 2024
* Add network/nptest module and update dependencies

* Merge branch 'kubernetes:master' into kubernetes-perf-tests-issues-kubernetes#2876

* Refactor the test details to tests.go

* Use declarative syntax for parsing logics

* Merge branch 'kubernetes:master' into kubernetes-perf-tests-issues-kubernetes#2876

* Export a lib function so that test can be run from another go program

* Change the name of module

* create an experimental package

* Some more experiments

* Removing replace directive

* Add replace directive

* Adding lib function be make the test reusable

* Update go.mod

* Merge Master

* Merge branch 'master' into improvements/experiment-2

* Minor Bug Fix and Add return type to the test

* Merge remote-tracking branch 'origin/master' into improvements/experiment-2
@ritwikranjan
Copy link
Author

ritwikranjan commented Oct 30, 2024

Bumping up the thread, Hey @aojea did you had the chance to take a look at the proposal?

@aojea
Copy link
Member

aojea commented Oct 30, 2024

Bumping up the thread, Hey @aojea did you had the chance to take a look at the proposal?

can you put the proposal in a shareable format? google docs, hackcmd or even a PR should be valid,

@ritwikranjan
Copy link
Author

ritwikranjan commented Oct 30, 2024

I have opened a PR #2969 with majority of the changes I have put in the proposal and I am going to make the proposal document in an online format as well. Let me know if this link works: https://1drv.ms/w/s!AlRV0Mo2jG1lg6RkJp4NRLNw9IOZNg?e=H7Fhdd, otherwise I will port it to google docs!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants