generate-jobs: handle generate section key
#34366
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bart0sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
sig/node
k8s-ci-robot
added
the
sig/testing
|
/sig node |
bart0sh
force-pushed
the
PR072-add-pull-kubernetes-node-e2e-containerd-2-0-dra-canary-job
branch
2 times, most recently
from
a4c6ea0 to
03dfe69
Compare
|
|
||
| # This job runs the same tests as ci-node-e2e-crio-dra with Containerd 2.0 runtime | ||
| [node-e2e-containerd-2-0-dra] | ||
| skip = ci,presubmit |
There was a problem hiding this comment.
The main use case is to generate only "canary" jobs, right? Would the opposite (an explicit allow list) make this more obvious?
generate = canary
If unset, all types get generated. If empty, nothing gets generated. May be useful to temporarily prevent generating something.
There was a problem hiding this comment.
The main use case is to generate only "canary" jobs, right?
I thought that it can be used to skip only ci jobs if we want to gradually propagate changes to canary, then to presubmit and at the end - to ci.
There was a problem hiding this comment.
If unset, all types get generated. If empty, nothing gets generated. May be useful to temporarily prevent generating something.
I think the current approach is more explicit, e.g. skip = canary,presubmit,ci looks more clear to me than generate = "". Probably just a matter of taste.
There was a problem hiding this comment.
If we have tested something as canary, then we don't need the immediate step with canary+presubmit because we already test the job as a presubmit. We don't want tests to run only in presubmits, so permanently generating only those without ever adding the periodic jobs also doesn't make sense.
That leaves these two scenarios:
skip = ci,presubmit # only canary
skip = ci,canary,presubmit # disable generation
The alternative is:
generate = canary # no comment needed here, self-explanatory
generate = # disable generation
Not sure. Anyone else have an opinion?
There was a problem hiding this comment.
@kannon92 @haircommander WDYT?
There was a problem hiding this comment.
It's perhaps worth adding that "only canary" is going to be the more common case by far. "Disable generation" was an afterthought.
bart0sh
force-pushed
the
PR072-add-pull-kubernetes-node-e2e-containerd-2-0-dra-canary-job
branch
2 times, most recently
from
2972a01 to
878fae0
Compare
bart0sh
changed the title
skip section keygenerate section key
Implemented generation only job types mentioned in the `generate` key for a certain section in the config file. If unset, all types get generated. If empty, nothing gets generated. Co-Authored-By: Patrick Ohly <[email protected]>
bart0sh
force-pushed
the
PR072-add-pull-kubernetes-node-e2e-containerd-2-0-dra-canary-job
branch
from
878fae0 to
2ba537c
Compare
generatekey for a certain section in the config file