Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: introduce a kube sandbox #34372

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

justinsb
Copy link
Member

The sandbox executor will be useful for running untrusted / semi-trusted code.

It runs commands in a kubernetes pod, using an agent for efficiency.

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 20, 2025
@justinsb
Copy link
Member Author

Part of the workstream to improve maintainer experience.

(We had some debates about whether this particular functionality belongs in the maintainers repo - owned by contrib-ex. Given that we're running code code similar to prow, maybe this is a better place for it.)

From the description on the prior PR:

This particular tool is basically a building block. The idea is to create a sandboxed executor that has no permissions (in particular, no github token). Then we can run scripts from repositories safely, and take the output and send it as a PR. The tool that drives that would be our second tool :-) And the goal is to run a script that lives in each repo, that updates the dependencies, and sends a PR. We need it for repos where dependabot simply doesn't work (in particular it seems to do badly for multi-module repos)

Of course once we have that functionality, repos can create more scripts to create PRs to do any toilsome task they want! And because they're PRs, worst case the outcome is PR spam.

One thing we want to solve vs prow and github actions is the ability to run scripts/tools and have them send PRs, and do that safely. (Note: the robots would send PRs, not merge directly to the repo, so worst case it is PR spam, but we still want to do that safely)

cc @ameukam and @BenTheElder

The sandbox executor will be useful for running untrusted / semi-trusted code.

It runs commands in a kubernetes pod, using an agent for efficiency.
@ameukam
Copy link
Member

ameukam commented Feb 20, 2025

cc @aojea
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@ameukam ameukam removed the request for review from cjwagner February 20, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants