Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for deprecation of Endpoints API #49831

Open
wants to merge 6 commits into
base: dev-1.33
Choose a base branch
from

Conversation

danwinship
Copy link
Contributor

Updates documentation to reflect the fact that Endpoints are now officially deprecated in 1.33 (KEP-4974).

This includes some updates to the EndpointSlice documentation to get rid of some historical baggage and focus on describing the API as it is now. (It does not add any of the missing information to the section about topology because that will need to be updated for KEP-3015 anyway so I'll just fix it all then.)

There are a lot of instances of the word "endpoints" in the documentation, but a lot of them refer to the generic concept. I think I've fixed most of them at least...

/label tide/merge-method-squash

- FQDN is not a supported AddressType

- Update documentation around `serving` vs `ready` to just explain how
  it works now, without the historical context. (In particular,
  describe `serving` first, and then explain `ready` as being almost
  the same thing as `serving` rather than vice versa).

- Fix feature-state version macro for `terminating`

- Remove a note about some deprecated v1beta1 EndpointSlice fields
  that is just confusing if you didn't know that v1beta1 had a
  different topology API.

- Remove the "Comparison with Endpoints"/"Motivation" section.
@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2025
Copy link

netlify bot commented Feb 19, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit a57fa8d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67b52907661a84000878c63d

[Endpoints](/docs/reference/kubernetes-api/service-resources/endpoints-v1/)
(the resource kind is plural) defines a list of network endpoints, typically
referenced by a Service to define which Pods the traffic can be sent to.
API. The Endpoints API is now deprecated, and has several problems
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
API. The Endpoints API is now deprecated, and has several problems
API. The deprecated Endpoints API has several problems

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't drop this glossary entry; it's useful even if we've deprecated it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok... I removed all the existing links to it though...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will still be hyperlinks to https://kubernetes.io/docs/reference/glossary/

@@ -1,17 +0,0 @@
---
title: Endpoints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could have a glossary entry for endpoint rather than Endpoints?

And then the revised entry could mention EndpointSlice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, effectively replace both existing glossary entries with the new combined one? Is there any way to make the old ones redirect? Or should I keep the old ones too, but just have basically the same information in all three?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the glossary entry id is endpoint. So we / you could:

  • explain what we mean by the term endpoint
  • mention EndpointSlices
  • find everywhere this glossary term is used within English docs, and check that the changes haven't made the page misleading
    • minimum viable rewrites where needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants