Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] content/ja/docs/concepts/containers/container-lifecycle-hooks.md follow of the en text #49851

Merged
merged 2 commits into from
Feb 23, 2025
Merged

[ja] content/ja/docs/concepts/containers/container-lifecycle-hooks.md follow of the en text #49851

merged 2 commits into from
Feb 23, 2025
+7 −2

Conversation

na2na-p
Copy link
Contributor

@na2na-p na2na-p commented Feb 21, 2025 •
edited
Loading

Description
Sync content/ja/docs/concepts/containers/container-lifecycle-hooks.md with the content in en.

Issue
Closes: #49850

/area localization
/language ja
/assign

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/localization General issues or PRs related to localization language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 21, 2025
@k8s-ci-robot k8s-ci-robot requested review from kakts and t-inu February 21, 2025 07:28
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @na2na-p!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2025
@na2na-p na2na-p marked this pull request as ready for review February 21, 2025 07:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6197ff5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67bb3a05095d2600084e470a
😎 Deploy Preview https://deploy-preview-49851--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya
Copy link
Member

Deploy preview: https://deploy-preview-49851--kubernetes-io-main-staging.netlify.app/ja/docs/concepts/containers/container-lifecycle-hooks/

@Okabe-Junya
Copy link
Member

/unassign na2na-p
/assign nasa9084

Kubernetes (kubernetes-sigs) org では、GitHub Assignee は Approver を貼り当てるために使用されるので、ご自身をassignしていただかなくて大丈夫です

@k8s-ci-robot k8s-ci-robot assigned nasa9084 and unassigned na2na-p Feb 23, 2025
@nasa9084
Copy link
Member

/approve
thank you for your first contribution!! 🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2025
Okabe-Junya
Okabe-Junya reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コントリビューションありがとうございます！
細かいですが1点だけコメントしたため、ご確認お願いします

@na2na-p
Copy link
Contributor Author

na2na-p commented Feb 23, 2025

/unassign na2na-p /assign nasa9084

Kubernetes (kubernetes-sigs) org では、GitHub Assignee は Approver を貼り当てるために使用されるので、ご自身をassignしていただかなくて大丈夫です

承知しました、ありがとうございます！

Okabe-Junya
Okabe-Junya reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改めてコントリビューションありがとうございます、LGTMです！

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 76e9069b1d761e526ac1ed412921cc6cd9c98430

@Okabe-Junya
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9587aee into kubernetes:main Feb 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okabe-Junya Okabe-Junya Okabe-Junya left review comments

@kakts kakts Awaiting requested review from kakts

@t-inu t-inu Awaiting requested review from t-inu

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@nasa9084 nasa9084

@Okabe-Junya Okabe-Junya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] content/ja/docs/concepts/containers/container-lifecycle-hooks.md follow of the en text
4 participants
@na2na-p @k8s-ci-robot @Okabe-Junya @nasa9084