-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Analyzer] UX - Error message improvement #2677
Comments
one more: i don’t understand the error like "Attribute "name" does not follow naming convention" and so on. what is wrong with this 'name"? and where user need to find this ''naming convention"? |
and one one more comment: |
On: "we say that something wrong with your Span name or Attribute name but we have no way to fix/edit them...then what is the sense of these messages? or maybe i don’t understand how this must work" - we will want to start tying the errors back to the definitions of what is 'correct'. For example, for attribute naming issues, we should have a hyper link that goes to https://opentelemetry.io/docs/specs/otel/common/attribute-naming/#:~:text=Attribute%20names%20that%20start%20with,t%20have%20a%20corresponding%20concept. This way the tool will start showing people the correct method. Another example, if an attribute was require on a http span and it was missing, we might provide a link to https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/http/#common-attributes We need to plan these things out via an epic, so for now I would not include the links and just focus on your changes to group like errors (which looks good) |
Please check the video https://www.loom.com/share/b3efe5ef26044db59c78cd4f0f72191b
See example:
Instead of this text:
i propose use this template:
Overall, the improvements aim to provide clearer explanations and actionable instructions to the user, making the error message more user-friendly and facilitating better understanding and resolution of the encountered issues.
The text was updated successfully, but these errors were encountered: