-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve analyzer errors #2743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jorgeepc great job! I added a couple of questions, let me know what you think
level: | ||
type: string | ||
description: | ||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include a field for the documentation URL? or is it your idea that it could be part of the suggestions
field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can decide that later. Now that we have the Error
struct we can increment the fields without breaking the compatibility.
This PR improves the implementation of
Analyzer Errors
by evolving the currenterrors
string array to a proper struct that can handle future enhancements like suggestions, error level, expected values, etc.Changes
Fixes
Checklist
Loom
https://www.loom.com/share/134da01378e54eae922298297f4fca9c?sid=a6484e4a-aa09-45f4-a0a9-b38df3e3b186