feat: change openapi spec for transactions to consider resource manager #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
reviewed
May 4, 2023
api/openapi.yaml
Outdated
| items: | ||
| type: array | ||
| items: | ||
| $ref: "./transactions.yaml#/components/schemas/Transaction" |
There was a problem hiding this comment.
Should we update this Transaction def to include the type and spec format?
There was a problem hiding this comment.
oh yeah, forgot we don't have those fields in this object. Fixing that!
schoren
suggested changes
May 4, 2023
There was a problem hiding this comment.
@mathnogueira there is one change that we need to implement, regarding the use of augmented entities. We have now 2 separated fields for Steps (full test) and stepIDs (just the ids).
For backwards compatibility with the yaml file, I used the steps name for the stepIDs, and fullSteps for the field containing the entire test definition of each step. Feel free to use a better name for this.
Something like this? Transaction:
type: object
properties:
steps:
type: array
description: list of steps of the transaction containing just each test id
items:
type: string
fullSteps:
type: array
description: list of steps of the transaction containing the whole test object
items:
$ref: "./tests.yaml#/components/schemas/Test" |
|
@mathnogueira yeap, exactly that! |
schoren
approved these changes
May 4, 2023
xoscar
added a commit
that referenced
this pull request
May 5, 2023
* change openapi spec for transactions to consider resource manager * use resource formatted object for input and output * add fullsteps field for transactions * Revert "feat: change openapi spec for transactions to consider resource manager" (#2497) Revert "feat: change openapi spec for transactions to consider resource manager (#2486)" This reverts commit 22f7dd1. --------- Co-authored-by: Matheus Nogueira <[email protected]>
4 tasks
schoren
pushed a commit
that referenced
this pull request
May 9, 2023
…er (#2486) * change openapi spec for transactions to consider resource manager * use resource formatted object for input and output * add fullsteps field for transactions
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
…er (#2486) * change openapi spec for transactions to consider resource manager * use resource formatted object for input and output * add fullsteps field for transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the CRUD operations on transactions to use the resource manager strategy
Checklist