feat: add upsert method and enable it for environments #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
reviewed
Jun 16, 2023
Comment on lines
269
to
280
| if err != nil { | ||
| if err == sql.ErrNoRows { | ||
| created, err := m.rh.Create(r.Context(), targetResource.Spec) | ||
| if err != nil { | ||
| writeError(w, encoder, http.StatusInternalServerError, fmt.Errorf("cannot create entity: %w", err)) | ||
| return | ||
| } | ||
|
|
||
| writeResponse(http.StatusCreated, created) | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggestion: we can join the two to avoid nesting:
Suggested change
| if err != nil { | |
| if err == sql.ErrNoRows { | |
| created, err := m.rh.Create(r.Context(), targetResource.Spec) | |
| if err != nil { | |
| writeError(w, encoder, http.StatusInternalServerError, fmt.Errorf("cannot create entity: %w", err)) | |
| return | |
| } | |
| writeResponse(http.StatusCreated, created) | |
| return | |
| } | |
| } | |
| if err != nil && err == sql.ErrNoRows { | |
| created, err := m.rh.Create(r.Context(), targetResource.Spec) | |
| if err != nil { | |
| writeError(w, encoder, http.StatusInternalServerError, fmt.Errorf("cannot create entity: %w", err)) | |
| return | |
| } | |
| writeResponse(http.StatusCreated, created) | |
| return | |
| } |
There was a problem hiding this comment.
Your suggestion made me realize I was ignoring the err when it was not a sql.ErrNoRows
xoscar
reviewed
Jun 16, 2023
| @@ -295,3 +295,33 @@ func (resourceClient ResourceClient) Create(ctx context.Context, file file.File) | |||
| file = file.SaveChanges(IOReadCloserToString(resp.Body)) | |||
| return &file, nil | |||
| } | |||
|
|
|||
| func (resourceClient ResourceClient) Upsert(ctx context.Context, file file.File) (*file.File, error) { | |||
There was a problem hiding this comment.
I like that we have this out of the box now
danielbdias
approved these changes
Jun 16, 2023
danielbdias
pushed a commit
that referenced
this pull request
Jun 16, 2023
* add upsert method and enable it for environments * handle error when getting entity
danielbdias
added a commit
that referenced
this pull request
Jun 16, 2023
* Adding initial APIs for the example * Adding code for payment-executor-api * Adding full example * Adding trace-based tests * Updating README * Apply suggestions from code review Co-authored-by: Adnan Rahić <[email protected]> * Adding documentation to the example * fix(backend): matching trigger span duration and trigger time durations (#2740) * fix(frontend): adding default value for data store connection types (#2742) * fix(backend): fixing response status code for grpc request (#2741) * feat: add upsert method and enable it for environments (#2746) * add upsert method and enable it for environments * handle error when getting entity * PR suggestions --------- Co-authored-by: Adnan Rahić <[email protected]> Co-authored-by: Oscar Reyes <[email protected]> Co-authored-by: Matheus Nogueira <[email protected]>
mathnogueira
added a commit
that referenced
this pull request
Jun 19, 2023
* add upsert method and enable it for environments * handle error when getting entity
mathnogueira
added a commit
that referenced
this pull request
Jun 19, 2023
* Adding initial APIs for the example * Adding code for payment-executor-api * Adding full example * Adding trace-based tests * Updating README * Apply suggestions from code review Co-authored-by: Adnan Rahić <[email protected]> * Adding documentation to the example * fix(backend): matching trigger span duration and trigger time durations (#2740) * fix(frontend): adding default value for data store connection types (#2742) * fix(backend): fixing response status code for grpc request (#2741) * feat: add upsert method and enable it for environments (#2746) * add upsert method and enable it for environments * handle error when getting entity * PR suggestions --------- Co-authored-by: Adnan Rahić <[email protected]> Co-authored-by: Oscar Reyes <[email protected]> Co-authored-by: Matheus Nogueira <[email protected]>
mathnogueira
added a commit
that referenced
this pull request
Jun 19, 2023
* add upsert method and enable it for environments * handle error when getting entity
mathnogueira
added a commit
that referenced
this pull request
Jun 19, 2023
* Adding initial APIs for the example * Adding code for payment-executor-api * Adding full example * Adding trace-based tests * Updating README * Apply suggestions from code review Co-authored-by: Adnan Rahić <[email protected]> * Adding documentation to the example * fix(backend): matching trigger span duration and trigger time durations (#2740) * fix(frontend): adding default value for data store connection types (#2742) * fix(backend): fixing response status code for grpc request (#2741) * feat: add upsert method and enable it for environments (#2746) * add upsert method and enable it for environments * handle error when getting entity * PR suggestions --------- Co-authored-by: Adnan Rahić <[email protected]> Co-authored-by: Oscar Reyes <[email protected]> Co-authored-by: Matheus Nogueira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method for upsert the resource into the database. And enables it for transactions
Checklist