feat(frontend): prepare api base url for submodule #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
approved these changes
Jul 28, 2023
| ) => { | ||
| const baseUrl = Env.get('baseApiUrl'); | ||
|
|
||
| return fetchBaseQuery({ |
There was a problem hiding this comment.
Thinking ahead a little bit, could we use something like this to inject the tokens or other things coming from the top source?
There was a problem hiding this comment.
Yes, that is the idea. Use this customBaseQuery to inject tokens, tenantId, etc.
| }), | ||
| }), | ||
| }); | ||
|
|
There was a problem hiding this comment.
I like this approach, if we want it to be even more flexible we could have it be a function which receives an API instance to inject the endpoints to, but this is not needed atm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to our
api/reduxfunctionality in the frontend app in order to support it as a git submodule.Changes
baseUrlFixes
Checklist