Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Improving attribute menu tooltip #3055

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Aug 10, 2023

This PR updates the behavior for the attribute list tooltip, showing it when users get to a test run for the first time and saving a flag to the user preferences (local storage) afterwards

Changes

  • Updates tooltip behavior
  • Adds localstorage flag
  • Fixex the tooltip animation

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/7b8227121ce54d8bb2abc816cb367b27

@xoscar xoscar requested review from jorgeepc and olha23 August 10, 2023 18:07
@xoscar xoscar self-assigned this Aug 10, 2023
@xoscar xoscar linked an issue Aug 10, 2023 that may be closed by this pull request
@xoscar xoscar marked this pull request as ready for review August 10, 2023 18:07
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

box-shadow: 0 0 0 0 ${theme.color.primaryLight};
}
`;

export const withPulseAnimation = (theme: DefaultTheme) => css`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with 👀

@xoscar xoscar merged commit 0c492fe into main Aug 10, 2023
@xoscar xoscar deleted the 2902-improve-attribute-menu-behaviour branch August 10, 2023 18:46
@olha23
Copy link

olha23 commented Aug 14, 2023

good,thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve attribute menu behaviour
3 participants