feature(frontend): Adding support for dynamic TracetestAPI instance #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
reviewed
Aug 17, 2023
server/executor/queue.go
Outdated
|
|
||
| var _ propagation.TextMapPropagator = tenantPropagator{} | ||
|
|
||
| // Inject sets baggage key-values from ctx into the carrier. |
There was a problem hiding this comment.
I think this comments are not correct
schoren
approved these changes
Aug 17, 2023
jorgeepc
approved these changes
Aug 18, 2023
node_modules/.package-lock.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "tracetest", | |||
| "name": "oss", | |||
package-lock.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "tracetest", | |||
| "name": "oss", | |||
| import {EndpointBuilder} from '@reduxjs/toolkit/dist/query/endpointDefinitions'; | ||
| import {TracetestApiTags} from '../../../constants/Test.constants'; | ||
|
|
||
| export type TTestApiEndpointBuilder = EndpointBuilder< |
There was a problem hiding this comment.
I think you already have this type here web/src/redux/apis/Tracetest/Tracetest.api.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the FE to use a dynamic instance for the tracetest API and fixes some issues with the backend regarding the tenant id queries
Changes
Checklist