feature(cli): Adding CLI cloud login and auth logic #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Aug 25, 2023
| @@ -271,6 +271,9 @@ func setupResources() { | |||
| extraHeaders := http.Header{} | |||
| extraHeaders.Set("x-client-id", analytics.ClientID()) | |||
| extraHeaders.Set("x-source", "cli") | |||
| extraHeaders.Set("x-organization-id", cliConfig.OrganizationID) | |||
There was a problem hiding this comment.
We are attaching the new headers as part of the request
There was a problem hiding this comment.
So we are always going to send this headers, right? even for OSS?
xoscar
commented
Aug 25, 2023
| cliConfig.Token = token | ||
| cliConfig.Jwt = jwt | ||
| serverPath := "" | ||
| cliConfig.ServerPath = &serverPath |
There was a problem hiding this comment.
We have to remove the /api server prefix
xoscar
commented
Aug 25, 2023
| @@ -47,7 +47,7 @@ func NewHTTPClient(baseURL string, extraHeaders http.Header) *HTTPClient { | |||
| } | |||
|
|
|||
| func (c HTTPClient) url(resourceName string, extra ...string) *url.URL { | |||
| urlStr := c.baseURL + path.Join("/api", resourceName, strings.Join(extra, "/")) | |||
| urlStr := c.baseURL + path.Join("/", resourceName, strings.Join(extra, "/")) | |||
There was a problem hiding this comment.
The prefix will be part of the server path now
jorgeepc
approved these changes
Aug 25, 2023
| var loginCmd = &cobra.Command{ | ||
| GroupID: cmdGroupCloud.ID, | ||
| Use: "login", | ||
| Short: "Tracetst Cloud Login", |
There was a problem hiding this comment.
Suggested change
| Short: "Tracetst Cloud Login", | |
| Short: "Tracetest Cloud Login", |
| GroupID: cmdGroupCloud.ID, | ||
| Use: "login", | ||
| Short: "Tracetst Cloud Login", | ||
| Long: "Initializes the Tracetst Cloud Login process", |
There was a problem hiding this comment.
Suggested change
| Long: "Initializes the Tracetst Cloud Login process", | |
| Long: "Initializes the Tracetest Cloud Login process", |
| @@ -271,6 +271,9 @@ func setupResources() { | |||
| extraHeaders := http.Header{} | |||
| extraHeaders.Set("x-client-id", analytics.ClientID()) | |||
| extraHeaders.Set("x-source", "cli") | |||
| extraHeaders.Set("x-organization-id", cliConfig.OrganizationID) | |||
There was a problem hiding this comment.
So we are always going to send this headers, right? even for OSS?
xoscar
added a commit
that referenced
this pull request
Sep 5, 2023
* feature(cli): Adding CLI cloud login and auth logic (#3100) * feature(cli): adding CLI cloud login and auth logic * feature(cli): adding CLI cloud login and auth logic * feat(cloud): adding support for cloud resources (#3101) * feature(cli): adding CLI cloud login and auth logic * feature(cli): adding CLI cloud login and auth logic * feat(cloud): adding support for cloud resources * feat(cloud): adding select command for cloud resources * feat(cloud): Tracetest configure improvements (#3102) * feature(cli): adding CLI cloud login and auth logic * feature(cli): adding CLI cloud login and auth logic * feat(cloud): adding support for cloud resources * feat(cloud): adding select command for cloud resources * fixing CLI e2e * Fixing missing prefix and CLI e2e tests * removing deprecation tests for environments * downgrading the goreleaser version * fixing CLI e2e * fixing status code * fixing FE port * fixing FE port * Implementing tracetest configure command * cleanup * adding missing select cmd * adding path validation for configure * re adding missing tests * feat(cli): adding `tracetest start` command (#3114) * feat(cli): adding start command * feat(cli): adding start command * feat(cli): cleanup and dynamic endpoint support (#3121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the base logic to support CLI cloud login and authentication
Changes
tracetest logincommandChecklist