Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache hit metrics #3214

Merged
merged 1 commit into from
Oct 4, 2023
Merged

feat: cache hit metrics #3214

merged 1 commit into from
Oct 4, 2023

Conversation

mathnogueira
Copy link
Contributor

This PR adds metrics on the test run cache, it keeps track of two things:

  • Number of cache requests (and register hits/misses)
  • Histogram of cache latency

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/4adc268b91a045409dbe216bb0c3a006

@mathnogueira mathnogueira mentioned this pull request Oct 4, 2023
Open
6 tasks
@mathnogueira mathnogueira merged commit e28f2d5 into main Oct 4, 2023
@mathnogueira mathnogueira deleted the feat/cache-metrics branch October 4, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@xoscar xoscar xoscar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathnogueira @jorgeepc @xoscar