chore: add a small warning for outdated CLIs #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathnogueira
commented
Dec 18, 2023
Comment on lines
-38
to
-63
| if !isSemver(version) || !isSemver(Version) { | ||
| // if either version is not semver, we can't compare them | ||
| // do a basic strict compare | ||
|
|
||
| versionMatch = version == Version | ||
| } else { | ||
|
|
||
| serverVersion, err := semver.NewVersion(version) | ||
| if err != nil { | ||
| return result + fmt.Sprintf(` | ||
| Server: Failed to parse the server version - %s`, err.Error()), false | ||
| } | ||
|
|
||
| cliVersion, err := semver.NewVersion(Version) | ||
| if err != nil { | ||
| return result + fmt.Sprintf(` | ||
| Failed to parse the CLI version - %s`, err.Error()), false | ||
| } | ||
|
|
||
| versionConstrait, err := semver.NewConstraint(fmt.Sprintf(">=%d.%d", cliVersion.Major(), cliVersion.Minor())) | ||
| if err != nil { | ||
| return result + fmt.Sprintf(` | ||
| Failed to parse the CLI version constraint - %s`, err.Error()), false | ||
| } | ||
|
|
||
| versionMatch = versionConstrait.Check(serverVersion) |
There was a problem hiding this comment.
I didn't change this logic (if you see any change, block the PR). I only detect if the CLI version if smaller than the server version and if so, show the outdated warning
danielbdias
approved these changes
Dec 18, 2023
| return false, false, fmt.Errorf("failed to parse the CLI version - %w", err) | ||
| } | ||
|
|
||
| versionConstrait, err := semver.NewConstraint(fmt.Sprintf(">=%d.%d", cliSemVer.Major(), cliSemVer.Minor())) |
There was a problem hiding this comment.
nit:
Suggested change
| versionConstrait, err := semver.NewConstraint(fmt.Sprintf(">=%d.%d", cliSemVer.Major(), cliSemVer.Minor())) | |
| versionConstraint, err := semver.NewConstraint(fmt.Sprintf(">=%d.%d", cliSemVer.Major(), cliSemVer.Minor())) |
jorgeepc
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small
(outdated)text next to the user CLI version in case there's a new version available (using the server version as reference)Checklist
Loom video
Add your loom video here if your work can be visualized