Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removing Tracking Backend Deletion #3467

Merged
merged 3 commits into from
Dec 20, 2023
Merged

chore: Removing Tracking Backend Deletion #3467

merged 3 commits into from
Dec 20, 2023

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Dec 20, 2023

This PR removes the ability to delete the current configured data store

Changes

  • Removes button to remove data store
  • Removes delete method from BE
  • Removes code from FE and open API

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

localhost_3001_settings

@xoscar xoscar self-assigned this Dec 20, 2023
@xoscar xoscar marked this pull request as ready for review December 20, 2023 18:49
@xoscar xoscar merged commit c5b4c1e into main Dec 20, 2023
37 checks passed
@xoscar xoscar deleted the chore-remove-delete-tracing-backend branch December 20, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@danielbdias danielbdias danielbdias approved these changes

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xoscar @jorgeepc @danielbdias