-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding instana as a tracing backend #3610
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -134,52 +134,55 @@ type SumoLogicConfig struct { | |||
} | |||
|
|||
const ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to my "OCD," I had to sort these data stores alphabetically to find our providers better.
Also, I fixed a typo where some data stores had the constant starting with Datastore
instead of DataStore
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adnanrahic and @jfermi, can you review this documentation file to see if everything is ok with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of editing suggestions.
Co-authored-by: Julianne Fermi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great job @danielbdias !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds Instana as an OTLP-based tracing backend for Tracetest
Changes
Settings > Tracing Backend
page./docs/docs/configuration/connecting-to-data-stores
How to manually test it
add/instana-integration-v1
make build-docker
./examples/quick-start-instana-nodejs
and create an.env
file with the following data:TAG=dev docker compose up -d
tracetest run test -f ./test-api.yaml --server-url=http://localhost:11633
http://localhost:11633
on your browser.Checklist
Loom video
https://www.loom.com/share/421fd9bc85174d4db89ac1c9a50635c4?sid=1344e71e-b8db-42ac-98ec-39a1b5e0d736