Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding instana as a tracing backend #3610

Merged
merged 9 commits into from
Feb 8, 2024

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Feb 7, 2024

This PR adds Instana as an OTLP-based tracing backend for Tracetest

Changes

  • Added FE icons and code for Instana on Wizard and Settings > Tracing Backend page
  • Added Instana as a Datastore on Backend API
  • Added example using Instana as a tracing backend
  • Added documentation page under ./docs/docs/configuration/connecting-to-data-stores

How to manually test it

  1. Check out the add/instana-integration-v1
  2. Create a new docker image for this code with make build-docker
  3. On terminal to ./examples/quick-start-instana-nodejs and create an .env file with the following data:
 

  1. Run the command TAG=dev docker compose up -d
  2. After everything is set, you can run a test using tracetest run test -f ./test-api.yaml --server-url=http://localhost:11633
  3. You see the UI changes by accessing http://localhost:11633 on your browser.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/421fd9bc85174d4db89ac1c9a50635c4?sid=1344e71e-b8db-42ac-98ec-39a1b5e0d736

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 7:42pm

@@ -134,52 +134,55 @@ type SumoLogicConfig struct {
}

const (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to my "OCD," I had to sort these data stores alphabetically to find our providers better.
Also, I fixed a typo where some data stores had the constant starting with Datastore instead of DataStore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adnanrahic and @jfermi, can you review this documentation file to see if everything is ok with it?

Copy link
Contributor

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of editing suggestions.

Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job @danielbdias !

Copy link
Contributor

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielbdias danielbdias merged commit 240b4e5 into main Feb 8, 2024
39 checks passed
@danielbdias danielbdias deleted the add/instana-integration-v1 branch February 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants