-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: SingleComboBoxの内部ロジックを整理する #5337
Open
AtsushiM
wants to merge
68
commits into
master
Choose a base branch
from
chore-refactoring-SingleComboBox
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+126
−128
Open
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
3bb40d3
chore: decoratorsのデフォルト文字列の持ち方を調整する
AtsushiM 5ef9eda
chore: DecoratorsTypeの設置場所を移動
AtsushiM 0d284e1
chore: useDecoratorsを定義
AtsushiM 139d213
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM 7f05277
chore: useDecoratorsにわたすgenericsを調整
AtsushiM 10baf9d
chore: libs/decorator を hooks/useDecorators に移動
AtsushiM 660292c
chore: fix stories
AtsushiM 485eebb
chore: ComboBoxのuseOptionsのisInputValueAddableの生成ロジックを整理する
AtsushiM ff3c853
chore: ComboBoxのuseOptionsのgetOptionIdは関数化する意味がないため解除
AtsushiM a4f8957
chore: ComboBoxのuseOptions内にexistedOptionsを定義
AtsushiM c515bea
chore: ComboBoxのuseOptions内のaddingOptionを切り出してmemo化
AtsushiM e69c2d1
chore: ComboBoxのuseOptions内のisInputValueAddableを整理
AtsushiM 2f619c4
chore: ComboBoxのuseOptions内のoptions生成方法を整理
AtsushiM 3838a06
chore: ComboBoxのuseOptionsでisSelectedのmemo効率を良くするため、hookを分割する
AtsushiM 0df395e
chore: ComboBoxのuseOptionsの型を整理
AtsushiM 430d1bf
chore: ComboBoxのuseOptionsの呼び出し方を最適化
AtsushiM ffb3ad7
chore: ComboBoxのuseOptionsのテストを修正
AtsushiM d32fe62
chore: ComboBoxのuseListBox内でsetTriggerWidth(0)の初期化処理は実施済みのため削除
AtsushiM db14a34
chore: ComboBoxのuseListBox内でisActiveTopOutside,isActiveBottomOutsideの…
AtsushiM 70ca015
chore: ComboBoxのuseListBoxでhandleKeyDownの条件分岐を最適化
AtsushiM b262f5d
chore: ComboBoxのuseListBoxでhandleAddのmemoを最適化する
AtsushiM 1f30d3a
chore: ComboBoxのuseListBoxでstyle, classNameのmemo化を分離する
AtsushiM b818a9d
chore: ComboBoxのuseListBoxでstyleの生成を完全にmemo化
AtsushiM 5187612
Merge branch 'chore-add-use-decorators' into chore-refactoring-ComboB…
AtsushiM d1a6ead
chore: ComboBoxのuseListBoxでdecoratorsをmemo化
AtsushiM 45437c2
chore: ComboBoxのuseListBoxでloadingTextの表示ロジックを調整
AtsushiM de097ed
chore: fix ci
AtsushiM 0969d97
chore: ComboBox/useLitBoxのkeyの判定を正規表現に行う
AtsushiM b8d522d
chore: ComboBox/useLitBoxのhookの依存関係を整理
AtsushiM d85caa1
chore: ListBoxItemButtonのisActiveは常にbooleanなので、余計なboolean化を削除
AtsushiM b83befc
chore: ListBoxItemButtonの最終出力で共通の属性を書き出す
AtsushiM 0e5373d
chore: ListBoxItemButtonのMemoizedNewIconWithTextを切り出す
AtsushiM c3bd8e4
chore: SingleComboBoxのif条件を整理
AtsushiM 3e83dd2
chore: SingleComboBoxのonFocusには常に関数を渡す必要がないため、handleFocusのmemo化を解除
AtsushiM a417dd0
chore: SingleComboBoxのuseClickのmemoを効率化
AtsushiM eae4db0
chore: SingleComboBoxでselectDefaultItem内部メソッドを定義
AtsushiM 332583c
chore: SingleComboBoxのstyle, className生成時のmemo化を分離する
AtsushiM 8295eaf
chore: SingleComboBoxのstylesの生成を最適化
AtsushiM cd1a914
Merge branch 'chore-add-use-decorators' into chore-refactoring-Single…
AtsushiM 08c9f52
chore: SingleComboBoxのdecoratorsの扱いを最適化
AtsushiM 549eec5
chore: SingleComboBoxのcaretに対してrole="presentation"を設定し、装飾的な要素であることを伝える
AtsushiM 74f1c62
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM ee9486f
Merge branch 'chore-add-use-decorators' into chore-refactoring-ComboB…
AtsushiM 7d25dcf
Merge branch 'chore-add-use-decorators' into chore-refactoring-Single…
AtsushiM 0a7be39
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM b40300f
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM 27dd66b
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM 772b7e3
chore: style -> className
AtsushiM ca5e096
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM 52634b8
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM a2d123d
chore: ListBoxItemButtonでkey設定は不要
AtsushiM 6abd1cc
chore: ListBoxItemButtonのisActiveの役割をactiveRefで補う
AtsushiM 5ba7ea8
chore: ListBoxItemButtonの内部分岐に合わせてコンポーネントを分割する
AtsushiM 9846bfc
chore: ListBoxItemButtonのclassName生成ロジックを整理
AtsushiM e55f36c
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM 36830a3
Merge branch 'chore-refactoring-ComboBox-useListBox' into chore-refac…
AtsushiM adccfab
chore: SingleComboboxのclassName生成を調整
AtsushiM 368d19b
chore: setterはmemo化の依存関係に含めなくて良いため調整
AtsushiM 7643b2c
chore: 属性の並び順を調整
AtsushiM ca7f518
chore: 配列での条件分岐を正規表現で行う
AtsushiM cb79af1
chore: ListBoxItemButtonのclassName生成ロジックを整理
AtsushiM 13f3c86
Merge branch 'chore-refactoring-ComboBox-useListBox' into chore-refac…
AtsushiM f16d2e9
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM 404ae3e
Merge branch 'chore-refactoring-ComboBox-useOptions' into chore-refac…
AtsushiM d7f3973
fix: StepFormDialogにuseResponseMessageを適用する
AtsushiM 8d6f263
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM 417fdff
Merge branch 'fix-response-message' into chore-refactoring-SingleComb…
AtsushiM 03f7789
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icon自体はmemo化されていますが、textにReact.Componentが渡されれば毎回再レンダリングされてしまいます。
幸いlabelが切り替わる可能性がないため、Icon毎Textを含めた状態でmemo化するようにしました