chore: Table関連の内部処理を整理 #5369
Open
chore: Table関連の内部処理を整理 #5369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-format-Table
branch
3 times, most recently
from
b972e35 to
142403c
Compare
yagimushi
force-pushed
the
chore-format-Table
branch
from
142403c to
294837c
Compare
commit: |
yagimushi
force-pushed
the
chore-format-Table
branch
from
be8b018 to
0587711
Compare
yagimushi
force-pushed
the
chore-format-Table
branch
from
0587711 to
c839dee
Compare
AtsushiM
commented
Feb 13, 2025
Comment on lines
+19
to
+29
| const actualClassName = useMemo(() => { | ||
| const base = classNameGenerator({ align, vAlign, nullable, fixed, className }) | ||
|
|
||
| if (!fixed) { | ||
| return base | ||
| } | ||
|
|
||
| const shadow = reelShadowClassNameGenerator({ direction: 'right' }) | ||
|
|
||
| return `${base} ${shadow}` | ||
| }, [align, className, contentWidth, fixed, nullable, style, vAlign]) |
There was a problem hiding this comment.
classNameの生成ロジックを整理しています。
trimなどが不要になります
AtsushiM
commented
Feb 13, 2025
Comment on lines
+180
to
+191
| upIcon: [ | ||
| 'shr-text-base', | ||
| '[[aria-sort="none"]_&]:shr-text-disabled', | ||
| '[[aria-sort="ascending"]_&]:shr-text-black', | ||
| '[[aria-sort="descending"]_&]:shr-text-disabled', | ||
| ], | ||
| downIcon: [ | ||
| '-shr-mt-em shr-text-base', | ||
| '[[aria-sort="none"]_&]:shr-text-disabled', | ||
| '[[aria-sort="ascending"]_&]:shr-text-disabled', | ||
| '[[aria-sort="descending"]_&]:shr-text-black', | ||
| ], |
There was a problem hiding this comment.
sortは切り替わる可能性が高く、またaria-sortで判定できるため、tailwind-variants内にstyle切り替えロジックを完全に押し込めています
AtsushiM
commented
Feb 13, 2025
| @@ -8,7 +8,7 @@ export const useReelCells = () => { | |||
| const currentRef = tableWrapperRef.current | |||
|
|
|||
| if (!currentRef) { | |||
| return () => undefined | |||
| return | |||
There was a problem hiding this comment.
useEffectの早期終了時にはnoopを渡す必要はないため、削除しています
AtsushiM
requested review from
misako0927 and
uknmr
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法