Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Textarea): rows指定が正しく動かないのを修正 #5394

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Feb 18, 2025

関連URL

https://kufuinc.slack.com/archives/CGC58MW01/p1739845995732009

概要

propsで渡されるrowsの初期値が入力後にブラウザの初期値に戻ってしまうのを修正

変更内容

propsで渡されるrowsの初期値が反映されないのを修正

確認方法

StorybookのTextarea/rowsで入力して高さが縮まないことを確認

@Qs-F Qs-F marked this pull request as ready for review February 18, 2025 04:33
@Qs-F Qs-F requested a review from a team as a code owner February 18, 2025 04:33
@Qs-F Qs-F requested review from moshisora and nabeliwo and removed request for a team February 18, 2025 04:33
Copy link

pkg-pr-new bot commented Feb 18, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5394

commit: 94470de

Copy link
Member

@AtsushiM AtsushiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AtsushiM AtsushiM merged commit 272a3c9 into master Feb 18, 2025
13 checks passed
@AtsushiM AtsushiM deleted the fix/textarea/rows-props-not-working branch February 18, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants