Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5.3.0 aarch64 #10

Open
wants to merge 6 commits into
base: aarch64
Choose a base branch
from

Conversation

GitSoftwareNow
Copy link

No description provided.

@minqian
Copy link
Collaborator

minqian commented Sep 25, 2020

Thank you for your support of arm ecology, we will review your code and make sure there is no problem to merge it.

src/fdr/fdr.c Outdated
#elif defined(HAVE_NEON)
__asm__ __volatile__("ldr w0, %w2 \n\t"
"bic %w0,w0,%w1 \n\t"
: "=r"(r)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our optimization, it is not recommended to modify.

src/fdr/fdr.c Outdated

u32 reach0, reach1, reach2, reach3;
u64a ptr = unaligned_load_u64a(itPtr);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also our optimization, it is not recommended to modify.

#define CRC32CB(crc, value) __asm__("crc32cb %w[c], %w[c], %w[v]":[c]"+r"(crc):[v]"r"(value))
#define CRC_WORD 8
#define CRC_TYPE u64a
static really_inline
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not recommended to modify for all of the “HAVE_NEON” branches.

}
#else
if (check_neon()) {
return HS_SUCCESS;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is needed for arm platform.

@@ -129,7 +129,7 @@ int RUN_EXCEPTION_FN(const EXCEPTION_T *e, STATE_ARG,
union RepeatControl *repeat_ctrl = ctx->repeat_ctrl + info->ctrlIndex;
char *repeat_state = ctx->repeat_state + info->stateOffset;

if (unlikely(e->trigger == LIMEX_TRIGGER_POS)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These branch predictions can improve the performance and are not recommended to be deleted.

kylin added 4 commits November 2, 2020 12:54
Signed-off-by: kylin <[email protected]>
Signed-off-by: kylin <[email protected]>
Signed-off-by: kylin <[email protected]>
Signed-off-by: kylin <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants