Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce version tag to NFRunning metric #222

Merged
merged 2 commits into from
Apr 18, 2023
Merged

feat: introduce version tag to NFRunning metric #222

merged 2 commits into from
Apr 18, 2023

Conversation

DecFox
Copy link
Contributor

@DecFox DecFox commented Apr 17, 2023

This diff introduces a new version tag to the l3afd_NFRunning metric.
Closes #221

jniesz
jniesz approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jniesz jniesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sanfern
sanfern approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@sanfern sanfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanfern sanfern merged commit 01696d6 into l3af-project:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfern sanfern sanfern approved these changes

@jniesz jniesz jniesz approved these changes

@charleskbliu0 charleskbliu0 Awaiting requested review from charleskbliu0 charleskbliu0 is a code owner

@dthaler dthaler Awaiting requested review from dthaler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric to monitor ebpf_program version running on the node
3 participants
@DecFox @sanfern @jniesz