L3AFD metric for ebpf program update command failure count #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atul-source <[email protected]>
Atul-source
requested review from
sanfern,
charleskbliu0,
jniesz,
dthaler,
ajayR006,
dalalkaran and
binojrajan
as code owners
dthaler
reviewed
Sep 26, 2023
stats/metrics.go
Outdated
| prometheus.CounterOpts{ | ||
| Namespace: daemonName, | ||
| Name: "NFUpdateFailedCount", | ||
| Help: "The count of Failed network functions updates", |
There was a problem hiding this comment.
Don't use the term "network function"
dthaler
requested changes
Sep 26, 2023
stats/metrics.go
Outdated
| Name: "NFUpdateFailedCount", | ||
| Help: "The count of Failed network functions updates", | ||
| }, | ||
| []string{"host", "ebpf_program", "direction", "interface_name"}, |
There was a problem hiding this comment.
why "ebpf_program" instead of "bpf_program"?
Signed-off-by: Atul-source <[email protected]>
dthaler
approved these changes
Oct 3, 2023
sanfern
pushed a commit
to sanfern/l3afd
that referenced
this pull request
Oct 24, 2023
…ect#283) * L3AFD metric for ebpf program update command failure count Signed-off-by: Atul-source <[email protected]>
sanfern
pushed a commit
to sanfern/l3afd
that referenced
this pull request
Oct 24, 2023
…ect#283) * L3AFD metric for ebpf program update command failure count Signed-off-by: Atul-source <[email protected]> Signed-off-by: sferna1 <[email protected]>
Atul-source
added a commit
to Atul-source/l3afd
that referenced
this pull request
Nov 28, 2023
…ect#283) * L3AFD metric for ebpf program update command failure count Signed-off-by: Atul-source <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new metric is added to track Update failures of eBPF Function. This PR fixes the issue reported in #282