Adding winzip artifact support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atul-source <[email protected]>
Atul-source
requested review from
sanfern,
satyaranjanp,
jniesz and
dthaler
as code owners
|
This PR is for Support artifact archiving in windows zip format #35. issue |
dthaler
approved these changes
May 27, 2022
Signed-off-by: Atul-source <[email protected]>
kf/bpf.go
Outdated
| return nil | ||
| } else { | ||
| return fmt.Errorf("Unknown Artifact format ") | ||
| } | ||
| return nil |
There was a problem hiding this comment.
This code is never reachable.
There was a problem hiding this comment.
I have removed unreachable code
can you review it again ?
Signed-off-by: a0p0ie5 <[email protected]>
satyaranjanp
approved these changes
Jun 1, 2022
Signed-off-by: a0p0ie5 <[email protected]>
sanfern
approved these changes
Jun 1, 2022
satyaranjanp
pushed a commit
to satyaranjanp/l3afd
that referenced
this pull request
Jun 2, 2022
Fix API doc structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Atul-source [email protected]