proto make: go get deprecation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installing executables with go get is deprecated
proto/Makefile install two programs which is not an importable package, this PR uses the go install instead of go get.
This also removes the go get -u github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger from deps recipe as starting with v2 grpc gateway which is currently being utilized in this project github.com/grpc-ecosystem/grpc-gateway/v2 v2.6.0 is not available and instead is available as openapi plugin which is also currently being utilized to generate doc.