Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signOut) Implementing signOut on iOS #37

Merged
merged 6 commits into from
Jan 17, 2022

Conversation

Gabriel-Azevedo
Copy link
Contributor

@Gabriel-Azevedo Gabriel-Azevedo commented Jan 17, 2022

What

Implementing signOut on iOS

Why

As discussed on #34, signOut on iOS was missing

How

Following the documentation

Copy link
Contributor

@danielgomezrico danielgomezrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature! You also updated the docs, awesome!

Copy link
Contributor

@cdmunoz cdmunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@cdmunoz cdmunoz added the enhancement New feature or request label Jan 17, 2022
@danielgomezrico
Copy link
Contributor

It looks like we have an issue on CI, lets wait a little to merge this until it is fixed, related to:
#38

@danielgomezrico
Copy link
Contributor

@Gabriel-Azevedo please do a rebase with master to see if CI works fine to merge it :)

@danielgomezrico danielgomezrico merged commit 0601a97 into la-haus:master Jan 17, 2022
@Gabriel-Azevedo Gabriel-Azevedo deleted the feature/signout-ios branch January 17, 2022 23:50
mixergtz pushed a commit that referenced this pull request Feb 11, 2022
* Removing checkRecentNotification on setNotificationOpenedHandler

Stop getting the last push payload every time handler is set

* Adding signOut function to iOS

* Code formatting

* reverting checkRecentNotification

* Updating readMe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants