Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Last Push Payload): when you open the app, reload the latest data from the push notification #42

Merged
merged 2 commits into from
May 2, 2022

Conversation

Santi92
Copy link
Contributor

@Santi92 Santi92 commented Apr 28, 2022

This will PR:

✅ Removes the checkRecentNotification from setNotificationOpenedHandler.
✅ Adjust unit test for checkRecentNotification.

issue open by @Gabriel-Azevedo on #35, since checkRecentNotification is called every time the app is opened (setNotificationOpenedHandler), even if the user already saw the push, every subsequent app open will trigger the push notification received flow.

Co-authored-by: @Gabriel-Azevedo .

@cdmunoz cdmunoz changed the title fix(lastPushPayload): when you open the app, reload the latest data from the push notification fix(Last Push Payload): when you open the app, reload the latest data from the push notification Apr 28, 2022
Copy link
Contributor

@cdmunoz cdmunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 💯

Copy link

@juansoos juansoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants