Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬇️ Pin mistune to <3.1.0 #2437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⬇️ Pin mistune to <3.1.0 #2437

wants to merge 1 commit into from

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Feb 7, 2025

3.1.1 got released which also doesn't work. https://pypi.org/project/mistune/

@Zethson Zethson marked this pull request as ready for review February 7, 2025 11:44
@Zethson Zethson requested a review from Koncopd February 7, 2025 11:46
@Zethson Zethson changed the title ⬇️ Pin mistune more strictly ⬇️ Pin mistune to <3.1.0 Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (d503387) to head (a3246f6).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2437      +/-   ##
==========================================
- Coverage   91.71%   91.15%   -0.57%     
==========================================
  Files          62       62              
  Lines        9138     8388     -750     
==========================================
- Hits         8381     7646     -735     
+ Misses        757      742      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 7, 2025

@github-actions github-actions bot temporarily deployed to pull request February 7, 2025 11:55 Inactive
@Koncopd
Copy link
Member

Koncopd commented Feb 8, 2025

What is the problem actually?

@Zethson
Copy link
Member Author

Zethson commented Feb 8, 2025

I am confused, I cannot reproduce it anymore. I had several errors for ln.finish() that went immediately away when I downgraded mistune. I'll keep observing...
I didn't copy the stacktrace back then because I saw that mistune was already pinned. Therefore I thought that the problem is already known

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants