Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored goto when a mixed list of command and state updates is returned from a node #3038

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix ignored goto when a mixed list of command and state updates is returned from a node #3038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions libs/langgraph/langgraph/graph/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import inspect

Check notice on line 1 in libs/langgraph/langgraph/graph/state.py

View workflow job for this annotation

GitHub Actions / benchmark

Benchmark results 

.........................................
fanout_to_subgraph_10x: Mean +- std dev: 62.9 ms +- 1.4 ms
.........................................
fanout_to_subgraph_10x_sync: Mean +- std dev: 55.0 ms +- 1.5 ms
.........................................
fanout_to_subgraph_10x_checkpoint: Mean +- std dev: 77.8 ms +- 1.5 ms
.........................................
fanout_to_subgraph_10x_checkpoint_sync: Mean +- std dev: 99.8 ms +- 1.4 ms
.........................................
fanout_to_subgraph_100x: Mean +- std dev: 676 ms +- 46 ms
.........................................
fanout_to_subgraph_100x_sync: Mean +- std dev: 534 ms +- 20 ms
.........................................
fanout_to_subgraph_100x_checkpoint: Mean +- std dev: 877 ms +- 54 ms
.........................................
fanout_to_subgraph_100x_checkpoint_sync: Mean +- std dev: 1.02 sec +- 0.04 sec
.........................................
react_agent_10x: Mean +- std dev: 30.7 ms +- 0.7 ms
.........................................
react_agent_10x_sync: Mean +- std dev: 22.9 ms +- 0.2 ms
.........................................
react_agent_10x_checkpoint: Mean +- std dev: 38.4 ms +- 0.8 ms
.........................................
react_agent_10x_checkpoint_sync: Mean +- std dev: 36.6 ms +- 0.5 ms
.........................................
react_agent_100x: Mean +- std dev: 345 ms +- 6 ms
.........................................
react_agent_100x_sync: Mean +- std dev: 271 ms +- 2 ms
.........................................
react_agent_100x_checkpoint: Mean +- std dev: 649 ms +- 12 ms
.........................................
react_agent_100x_checkpoint_sync: Mean +- std dev: 639 ms +- 17 ms
.........................................
wide_state_25x300: Mean +- std dev: 23.5 ms +- 0.5 ms
.........................................
wide_state_25x300_sync: Mean +- std dev: 15.5 ms +- 0.2 ms
.........................................
wide_state_25x300_checkpoint: Mean +- std dev: 254 ms +- 16 ms
.........................................
wide_state_25x300_checkpoint_sync: Mean +- std dev: 249 ms +- 15 ms
.........................................
wide_state_15x600: Mean +- std dev: 27.4 ms +- 0.7 ms
.........................................
wide_state_15x600_sync: Mean +- std dev: 17.9 ms +- 0.1 ms
.........................................
wide_state_15x600_checkpoint: Mean +- std dev: 432 ms +- 15 ms
.........................................
wide_state_15x600_checkpoint_sync: Mean +- std dev: 433 ms +- 18 ms
.........................................
wide_state_9x1200: Mean +- std dev: 27.4 ms +- 0.6 ms
.........................................
wide_state_9x1200_sync: Mean +- std dev: 18.0 ms +- 0.3 ms
.........................................
wide_state_9x1200_checkpoint: Mean +- std dev: 284 ms +- 16 ms
.........................................
wide_state_9x1200_checkpoint_sync: Mean +- std dev: 283 ms +- 16 ms

Check notice on line 1 in libs/langgraph/langgraph/graph/state.py

View workflow job for this annotation

GitHub Actions / benchmark

Comparison against main 

+-----------------------------------------+---------+------------------------+
| Benchmark                               | main    | changes                |
+=========================================+=========+========================+
| wide_state_15x600_checkpoint            | 439 ms  | 432 ms: 1.01x faster   |
+-----------------------------------------+---------+------------------------+
| wide_state_15x600_sync                  | 18.1 ms | 17.9 ms: 1.01x faster  |
+-----------------------------------------+---------+------------------------+
| wide_state_15x600                       | 27.6 ms | 27.4 ms: 1.01x faster  |
+-----------------------------------------+---------+------------------------+
| react_agent_100x_sync                   | 273 ms  | 271 ms: 1.01x faster   |
+-----------------------------------------+---------+------------------------+
| wide_state_25x300_sync                  | 15.6 ms | 15.5 ms: 1.00x faster  |
+-----------------------------------------+---------+------------------------+
| react_agent_100x                        | 343 ms  | 345 ms: 1.01x slower   |
+-----------------------------------------+---------+------------------------+
| fanout_to_subgraph_10x                  | 62.5 ms | 62.9 ms: 1.01x slower  |
+-----------------------------------------+---------+------------------------+
| react_agent_100x_checkpoint             | 640 ms  | 649 ms: 1.02x slower   |
+-----------------------------------------+---------+------------------------+
| fanout_to_subgraph_10x_sync             | 54.2 ms | 55.0 ms: 1.02x slower  |
+-----------------------------------------+---------+------------------------+
| fanout_to_subgraph_10x_checkpoint       | 75.9 ms | 77.8 ms: 1.03x slower  |
+-----------------------------------------+---------+------------------------+
| fanout_to_subgraph_10x_checkpoint_sync  | 97.0 ms | 99.8 ms: 1.03x slower  |
+-----------------------------------------+---------+------------------------+
| react_agent_100x_checkpoint_sync        | 620 ms  | 639 ms: 1.03x slower   |
+-----------------------------------------+---------+------------------------+
| fanout_to_subgraph_100x_checkpoint_sync | 982 ms  | 1.02 sec: 1.04x slower |
+-----------------------------------------+---------+------------------------+
| fanout_to_subgraph_100x                 | 620 ms  | 676 ms: 1.09x slower   |
+-----------------------------------------+---------+------------------------+
| fanout_to_subgraph_100x_checkpoint      | 782 ms  | 877 ms: 1.12x slower   |
+-----------------------------------------+---------+------------------------+
| Geometric mean                          | (ref)   | 1.01x slower           |
+-----------------------------------------+---------+------------------------+

Benchmark hidden because not significant (13): wide_state_25x300_checkpoint_sync, wide_state_9x1200_checkpoint, react_agent_10x, wide_state_25x300_checkpoint, wide_state_9x1200, react_agent_10x_sync, react_agent_10x_checkpoint_sync, wide_state_9x1200_sync, wide_state_25x300, wide_state_15x600_checkpoint_sync, react_agent_10x_checkpoint, fanout_to_subgraph_100x_sync, wide_state_9x1200_checkpoint_sync
import logging
import typing
import warnings
Expand Down Expand Up @@ -847,14 +847,10 @@
commands: list[Command] = []
if isinstance(value, Command):
commands.append(value)
elif (
isinstance(value, (list, tuple))
and value
and all(isinstance(i, Command) for i in value)
):
commands.extend(value)
else:
return EMPTY_SEQ
elif isinstance(value, (list, tuple)):
for cmd in value:
if isinstance(cmd, Command):
commands.append(cmd)
rtn: list[Union[str, Send]] = []
for command in commands:
if command.graph == Command.PARENT:
Expand All @@ -874,14 +870,10 @@
commands: list[Command] = []
if isinstance(value, Command):
commands.append(value)
elif (
isinstance(value, (list, tuple))
and value
and all(isinstance(i, Command) for i in value)
):
commands.extend(value)
else:
return EMPTY_SEQ
elif isinstance(value, (list, tuple)):
for cmd in value:
if isinstance(cmd, Command):
commands.append(cmd)
rtn: list[Union[str, Send]] = []
for command in commands:
if command.graph == Command.PARENT:
Expand Down
Loading