-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.x] use fenced code blocks #10172
[12.x] use fenced code blocks #10172
Conversation
- better syntax highlighting - easier copy/pasting of code examples - consistency throughout docs block
@browner12 merged 11.x -> master just now. |
Since Laravel uses Torchlight, fenced code blocks also allow for a variety of other awesome features, where beneficial: |
This also allows for the opportunity to make code samples more consistent:
|
yup. one step at a time here. keeping it simple to make reviews easier. |
@taylorotwell I started on these changes, and then realized none of my recent indentation changes on 11.x were pulled into master yet. Would those changes merge cleanly into this, or create a lot of manual review merge conflicts? Wanted to double check before I added a lot of extra work for you or me. If they won't merge cleanly, I can just wait for 12.x to come out. If it'll be okay, just convert this to a draft, and I'll keep going.