Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] use fenced code blocks #10172

Merged

Conversation

browner12
Copy link
Contributor

  • better syntax highlighting
  • easier copy/pasting of code examples
  • consistency throughout docs block

@taylorotwell I started on these changes, and then realized none of my recent indentation changes on 11.x were pulled into master yet. Would those changes merge cleanly into this, or create a lot of manual review merge conflicts? Wanted to double check before I added a lot of extra work for you or me. If they won't merge cleanly, I can just wait for 12.x to come out. If it'll be okay, just convert this to a draft, and I'll keep going.

- better syntax highlighting
- easier copy/pasting of code examples
- consistency throughout docs block
@taylorotwell
Copy link
Member

@browner12 merged 11.x -> master just now.

@taylorotwell taylorotwell marked this pull request as draft February 17, 2025 18:39
@shaedrich
Copy link
Contributor

  • better syntax highlighting
  • easier copy/pasting of code examples
  • consistency throughout docs block

Since Laravel uses Torchlight, fenced code blocks also allow for a variety of other awesome features, where beneficial:

@shaedrich
Copy link
Contributor

shaedrich commented Feb 17, 2025

Since Laravel uses Torchlight, fenced code blocks also allow for a variety of other awesome features, where beneficial

This also allows for the opportunity to make code samples more consistent:

  • Include or omit <?php
  • Include or omit use statements
  • Include or omit surrounding context and "setup" "boilerplate"
  • Collapse intermediate lines with or without // …, with another sign, or don't collapse at all
  • etc.

see laravel/framework#53244

@browner12
Copy link
Contributor Author

yup. one step at a time here. keeping it simple to make reviews easier.

@browner12 browner12 marked this pull request as ready for review February 19, 2025 06:58
@taylorotwell taylorotwell merged commit 1ab9932 into laravel:master Feb 19, 2025
@browner12 browner12 deleted the AB-explicit-language-code-blocks branch February 19, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants