[5.8] Add shouldReport method to the ExceptionHandler interface #26193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Coder264
force-pushed
the
add-should-report-method-to-the-exception-handler-interface
branch
from
5e31395 to
16d58af
Compare
X-Coder264
deleted the
add-should-report-method-to-the-exception-handler-interface
branch
okdewit
added a commit
to okdewit/browser-kit-testing
that referenced
this pull request
Mar 10, 2019
shouldReport was added to the ExceptionHandler interface. This throws an error when calling withoutExceptionHandling() from Laravel 5.8. laravel/framework#26193
okdewit
added a commit
to okdewit/collision
that referenced
this pull request
Mar 11, 2019
`shouldReport()` was added to the `ExceptionHandler` interface in Laravel 5.8. When it is not present in this class, it throws an error. See this PR on Laravel Framework: laravel/framework#26193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this method should be in the interface.
nunomaduro/collision#56
🔭