[5.8] Fix View contract violations #26754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no method on the contract to access the view data even though one was obviously needed - this also meant that all the code in the framework which was trying to access the view data was violating the contract (e.g. in
TestResponse
). TheensureResponseHasView
literally checks if$this->original
is an instance of theView
contract and then after that the data is accessed like this:$this->original->$key
(this would obviously break with any other implementation of the contract). Fixing this requires adding thegetData
method to the contract.The
assertViewIs
method inTestResponse
was calling thegetName
method which is not on the contract, whilename
is and should be used instead as it gives the same result.