[5.8] Use Mailable contract instead of class #26790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmokkenstorm
changed the title
nmokkenstorm
changed the title
TBlindaruk
changed the title
koenhoeijmakers
approved these changes
Dec 8, 2018
|
Looks good to me, superficially at least. 👍 |
|
It's a very superficial change to be honest. I'm definitely willing into digging into the framework code at a later point to make registering custom mail drivers easier, if that kind of thing would be welcomed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This shouldn't break any existing code, but at my current employer I wanted to add a custom mail driver, and integrate that with the framework as much as possible, but was unable to do so because PendingMail depends on a concrete instance of Mailable, instead of the contract.
This PR solves my issue, and maybe make it easier to add custom mail drivers for everyone in the future.