Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Add Deferred interface for service providers #27067

Merged
merged 3 commits into from
Jan 5, 2019
Merged

[5.8] Add Deferred interface for service providers #27067

merged 3 commits into from
Jan 5, 2019

Conversation

svenluijten
Copy link
Contributor

@svenluijten svenluijten commented Jan 4, 2019 •
edited
Loading

As discussed and explained in laravel/ideas#1453.

If accepted, I will also update the documentation to only recommend using this interface, and leave the $defer property undocumented. This way we can remove the property altogether from the 5.9 release (or 5.10, whichever is preferred).

@imanghafoori1
Copy link
Contributor

You may change the name of the interface from Deferred to
DeferredProvider or DeferredServiceProvider

That name is too short, I think...

@taylorotwell
Copy link
Member

I would call the interface "DeferrableProvider"

@taylorotwell taylorotwell merged commit e5bf646 into laravel:master Jan 5, 2019
This was referenced Jan 5, 2019
Merged
Closed
@svenluijten svenluijten deleted the deferred-interface branch January 10, 2019 08:19
@X-Coder264 X-Coder264 mentioned this pull request Jan 10, 2019
Merged
taylorotwell pushed a commit to illuminate/support that referenced this pull request Feb 7, 2019
@driesvints
Indicate defer property removal
4999fac 
This property was deprecated by an alternative implementation in laravel/framework#27067 and should be removed in the next major release.
TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 17, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
c243d09 
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 17, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
c2c1a1e 
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons`
- property `bindings`
TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 17, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
4d0aa8e 
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
@TBlindaruk TBlindaruk mentioned this pull request Feb 17, 2019
Merged
TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 18, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
086a7e5 
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 18, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
f7fc225 
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 18, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
aa411cc 
…f the contract In the laravel#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/auth that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
41d2365 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/auth that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
e5c1248 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/broadcasting that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
3f4d9e8 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/broadcasting that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
26bc2cf 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/bus that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
af333c6 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/bus that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
6a15b03 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/cache that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
5b9db6a 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/cache that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
d693086 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/contracts that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
7276e27 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/contracts that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
3e3a9a6 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/cookie that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
e9580fc 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/cookie that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
71de5c9 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/log that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
62a6072 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/mail that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
ee3faba 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/mail that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
3a184e8 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/notifications that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
b0a3707 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/notifications that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
2581f64 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/pagination that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
5f9b589 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/pagination that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
e02260a 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/pipeline that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
e417186 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/pipeline that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
05b012e 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/queue that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
11bd831 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/queue that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
909c0c2 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/redis that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
a03c135 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/redis that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
df76111 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/routing that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
dca3360 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/routing that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
a4aa0de 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/session that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
c75cc2f 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/session that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
15b4d36 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/support that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
d26981f 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/support that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
77764a1 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/translation that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
5c159ec 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/translation that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
7d9cc54 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/validation that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
971bdd8 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/validation that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
ee7cb20 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
taylorotwell pushed a commit to illuminate/view that referenced this pull request Feb 23, 2019
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
de205bc 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/view that referenced this pull request Feb 23, 2019
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
cd5a61d 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
This was referenced Feb 26, 2019
Merged
Merged
luceos pushed a commit to tenancy/multi-tenant that referenced this pull request Feb 27, 2019
@ArlonAntonius @luceos
Laravel 5.8 Compatibility (#731)
864041d 
As per Laravel 5.8 the Defer variable in Service Providers is [deprecated](laravel/framework#27067). This PR simply fixes the deferrable provider per their requirements, would break compatibility with 5.7 though.
taylorotwell pushed a commit to illuminate/view that referenced this pull request May 11, 2021
@TBlindaruk
[5.8] Make register method in the ServiceProvider as part of the co…
d5cc47f 
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`
taylorotwell pushed a commit to illuminate/view that referenced this pull request May 11, 2021
@TBlindaruk
Revert "[5.8] Make register method in the ServiceProvider as part o…
4085abf 
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svenluijten @imanghafoori1 @taylorotwell