Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoscaler scaling down below zero when (nr. of queues * minProcesses) is higher than maxProcesses #1292

Merged

Conversation

PrinsFrank
Copy link
Contributor

@PrinsFrank PrinsFrank commented Jun 30, 2023

Example reproduction:

'environments' => [
    'production' => [
        'queue' => ['default', 'low-prio', 'high-prio'],
        'minProcesses' => 2,
        'maxProcesses' => 5,
    ]
]

Will result in all queues being scaled down to 0. After this fix, they will be scaled to 1 instead as 2 is not possible for all queues.

Alternative fix is #1289, but that will throw an exception on invalid configuration, which is breaking.

@taylorotwell taylorotwell merged commit b14498a into laravel:5.x Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants