Fixed client runtime #174
Fixed client runtime #174
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 61.39% 61.13% -0.26%
==========================================
Files 36 36
Lines 1202 1194 -8
Branches 8 7 -1
==========================================
- Hits 738 730 -8
Misses 464 464
Continue to review full report at Codecov.
|
| tb.parse { | ||
| s"""import laserdisc._ | ||
| |import laserdisc.auto._ | ||
| |import laserdisc.all._ |
There was a problem hiding this comment.
i think we need this for now (see here) or we lose the ability to just invoke all protocols w/o prefix in the CLI
There was a problem hiding this comment.
I think the protocols in all are already imported by laserdisc._. If I add it and run
localhost:6379> strings.set("a", 23)
I get
reflective compilation has failed:
reference to strings is ambiguous;
it is imported twice in the same scope by
import laserdisc.all._
and import laserdisc._
localhost:6379>
The one that doesn't seem to be found is BListP though. Do they need to be hierarchical ?
There was a problem hiding this comment.
Yeah, in theory it should be just set(“a”, 23)
strings is another object that extends StringP (Like all, which extends all protocols)
| @@ -4,6 +4,7 @@ package fs2 | |||
| import java.net.InetSocketAddress | |||
|
|
|||
| import _root_.fs2.{Chunk, Pull} | |||
There was a problem hiding this comment.
| import _root_.fs2.{Chunk, Pull} |
| @@ -7,3 +7,4 @@ addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.29") | |||
| addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.3.7") | |||
| addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.6.0") | |||
| addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.10.0-RC1") | |||
| addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.10") | |||
There was a problem hiding this comment.
I need it to produce the the CLI assembly. It doesn't work in sbt so I have to run it trough the Jar. That's still a problem, I couldn't find a way to make it progress in an sbt run. It hangs and needs to be killed. If started with
java -jar <the jar> localhost 6379
works fine.
There was a problem hiding this comment.
And yes, would love to understand why it hangs there if used within sbt
| serverUnavailable.flatMap(address => runner(Stream.emit(Some(address)))) | ||
|
|
||
| case _ => | ||
| case None => |
There was a problem hiding this comment.
are we not missing a case now?
|
|
|
I'm spending a bit of time trying find out why CLI hangs or, if I fork the jvm on run, doesn't stop waiting for input but successfully finishes. |
|
I pushed the missing import. I have another strategy in mind for the CLI, but it deserves a separate PR. I would merge this as it is then. |
This should reestablish correctness of the client and the CLI after the upgrade to the latest fs2. I will address possible performance regressions and the automation to build the CLI in follow-up PRs.