Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 46: Add laws verification for Read #198

Merged
merged 4 commits into from
Dec 27, 2019
Merged

Issue 46: Add laws verification for Read #198

merged 4 commits into from
Dec 27, 2019

Conversation

barambani
Copy link
Member

This is a first attempt at #46 . A couple of notes. The most important, I couldn't find a way to make our Read flatMap or the instance tailRecM stack safe so for now I'm checking the stackUnsafeMonad laws. Also the Eq definition I used for Read is based on a single sample. I might add some other attempts.

@barambani barambani requested a review from sirocchj as a code owner December 26, 2019 02:12
@barambani
Copy link
Member Author

One more thing, I didn't define the Invariant functor as our Contravariant doesn't act on the same type parameter as the Covariant. We will have to decide if and how we want the invariant to be.

@codecov-io
Copy link

codecov-io commented Dec 26, 2019

Codecov Report

Merging #198 into master will increase coverage by 0.08%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   59.71%   59.79%   +0.08%     
==========================================
  Files          37       38       +1     
  Lines        1276     1291      +15     
  Branches        7        8       +1     
==========================================
+ Hits          762      772      +10     
- Misses        514      519       +5
Impacted Files Coverage Δ
core/src/main/scala/laserdisc/protocol/Read.scala 76.66% <100%> (+1.03%) ⬆️
.../main/scala/laserdisc/protocol/ReadInstances.scala 57.14% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae47cc5...e0259f4. Read the comment docs.

sirocchj
sirocchj previously approved these changes Dec 26, 2019
Copy link
Member

@sirocchj sirocchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@barambani barambani merged commit 9f3fff7 into laserdisc-io:master Dec 27, 2019
@barambani barambani deleted the issue-46 branch December 27, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants