Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated core tests to munit #265

Merged
merged 4 commits into from
May 27, 2020
Merged

Migrated core tests to munit #265

merged 4 commits into from
May 27, 2020

Conversation

barambani
Copy link
Member

No description provided.

@barambani barambani requested a review from sirocchj as a code owner May 23, 2020 19:31
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   62.17%   62.17%           
=======================================
  Files          38       38           
  Lines        1285     1285           
  Branches        8        8           
=======================================
  Hits          799      799           
  Misses        486      486           
Impacted Files Coverage Δ
core/src/main/scala/laserdisc/protocol/KeyP.scala 87.20% <0.00%> (-1.17%) ⬇️
...c/main/scala/laserdisc/protocol/EitherSyntax.scala 85.71% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a56ab...0be7074. Read the comment docs.

sirocchj
sirocchj previously approved these changes May 27, 2020
"given one or more keys and timeout" in forAll("keys", "timeout", "returned value") { (ks: OneOrMoreKeys, nni: NonNegInt, i: Int) =>
val protocol = blpop[Int](ks, nni)
abstract class BListPSpec extends BaseSpec with BListP {
test("The Blocking List extended protocol using blpop fails to compile given key but missing read instance") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is testing non compilation of the extended protocol, i.e. the 1-arity call with Key, it was in the template, happy to move it here if it makes it more readable but then careful below when giving other property names

}
}
}
test("The Blocking List extended protocol using blpop fails to compile given one key and timeout but missing read instance") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not an extended protocol non compilation test, it's asserting the "regular" protocol with OneOrMoreKeys fails to compile when no read instance is available in implicit scope.

}
}
test(
"A RESP codec checking the state of a bit vector whit the size prefix complete and an incomplete payload gives MissingBits with the correct number of bits missing"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"A RESP codec checking the state of a bit vector whit the size prefix complete and an incomplete payload gives MissingBits with the correct number of bits missing"
"A RESP codec checking the state of a bit vector with the size prefix complete and an incomplete payload gives MissingBits with the correct number of bits missing"

@barambani barambani merged commit bae7380 into laserdisc-io:master May 27, 2020
@barambani barambani deleted the core-munit branch May 27, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants