-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated core tests to munit #265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=======================================
Coverage 62.17% 62.17%
=======================================
Files 38 38
Lines 1285 1285
Branches 8 8
=======================================
Hits 799 799
Misses 486 486
Continue to review full report at Codecov.
|
"given one or more keys and timeout" in forAll("keys", "timeout", "returned value") { (ks: OneOrMoreKeys, nni: NonNegInt, i: Int) => | ||
val protocol = blpop[Int](ks, nni) | ||
abstract class BListPSpec extends BaseSpec with BListP { | ||
test("The Blocking List extended protocol using blpop fails to compile given key but missing read instance") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is testing non compilation of the extended protocol, i.e. the 1-arity call with Key
, it was in the template, happy to move it here if it makes it more readable but then careful below when giving other property names
} | ||
} | ||
} | ||
test("The Blocking List extended protocol using blpop fails to compile given one key and timeout but missing read instance") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not an extended protocol non compilation test, it's asserting the "regular" protocol with OneOrMoreKeys
fails to compile when no read instance is available in implicit scope.
} | ||
} | ||
test( | ||
"A RESP codec checking the state of a bit vector whit the size prefix complete and an incomplete payload gives MissingBits with the correct number of bits missing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"A RESP codec checking the state of a bit vector whit the size prefix complete and an incomplete payload gives MissingBits with the correct number of bits missing" | |
"A RESP codec checking the state of a bit vector with the size prefix complete and an incomplete payload gives MissingBits with the correct number of bits missing" |
No description provided.