Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming inconsistency in output files / documentation #64

Closed
RalfG opened this issue May 3, 2023 · 2 comments
Closed

Naming inconsistency in output files / documentation #64

RalfG opened this issue May 3, 2023 · 2 comments

Comments

@RalfG
Copy link
Contributor

RalfG commented May 3, 2023

Hi @lazear,

First and foremost, thanks for the great work!

Continuing the conversation from compomics/psm_utils#31: It seems that internally, the _q suffix is indeed used as is also documented for the result.sage.tsv output:
https://github.com/lazear/sage/blob/5f95d454f9b126cf93b2ec96443f4aaa8a88f588/crates/sage-cli/src/output.rs#L62C21-L64

However, the header names use the _fdr suffix:
https://github.com/lazear/sage/blob/f55a9e525cf353de94e194428a3a5615d0cbab8c/crates/sage-cli/src/output.rs#L113C18-L115

Personally, I think the _q suffix makes more sense, but for backwards compatibility (which might not be so much of an issue yet), you could opt to keep the _fdr suffix.

@lazear
Copy link
Owner

lazear commented May 3, 2023

I agree, the _q suffix makes more sense (and is correct). I think I initially changed it to fdr to clarify for any users that don't know what q-values are. I will leave this issue open for a week or so in case someone wants to voice opposition to using spectrum_q, etc instead of spectrum_fdr.

@radusuciu
Copy link

+1 for _q, I forget where I first came across this but when I see q in this context I immediately think: "adjusted FDR"

lazear added a commit that referenced this issue May 11, 2023
@lazear lazear closed this as completed May 11, 2023
lazear added a commit to lazear/psm_utils that referenced this issue Jun 17, 2023
Re: lazear/sage#64

Looks like I somehow forgot to change this in the DOCS.md file!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants